diff options
| author | Henrik Edin <henrik.edin@mongodb.com> | 2020-09-17 17:09:19 -0400 |
|---|---|---|
| committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2020-09-26 02:12:49 +0000 |
| commit | 2b82ab88982566114d1bb7667477b71c883b0799 (patch) | |
| tree | c152b35ff047fdc42f69aa6cd6b04fee1d811fe4 /src/mongo/db/repl/storage_interface.h | |
| parent | 08e92a678a1ed288f6a95e7950597e082556ae59 (diff) | |
| download | mongo-2b82ab88982566114d1bb7667477b71c883b0799.tar.gz | |
SERVER-50984 Add CollectionPtr to replace usage of const Collection*
It implements a yieldable interface that is used to re-load the
Collection pointer from the catalog after a yield that released locks.
With lock-free reads and copy-on-write on Collection instances releasing
locks without notifying an AutoGetCollection at a higher level may cause
its pointers to dangle if a MODE_X writer installs a new Collection
instance in the catalog.
CollectionPtr should be passed by const reference so a yield can notify
all the way up.
Diffstat (limited to 'src/mongo/db/repl/storage_interface.h')
| -rw-r--r-- | src/mongo/db/repl/storage_interface.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/mongo/db/repl/storage_interface.h b/src/mongo/db/repl/storage_interface.h index ef8af4ac2c1..098df44021d 100644 --- a/src/mongo/db/repl/storage_interface.h +++ b/src/mongo/db/repl/storage_interface.h @@ -47,6 +47,7 @@ namespace mongo { class Collection; +class CollectionPtr; struct CollectionOptions; class OperationContext; @@ -326,7 +327,7 @@ public: * matches are found. */ virtual boost::optional<BSONObj> findOplogEntryLessThanOrEqualToTimestamp( - OperationContext* opCtx, const Collection* oplog, const Timestamp& timestamp) = 0; + OperationContext* opCtx, const CollectionPtr& oplog, const Timestamp& timestamp) = 0; /** * Calls findOplogEntryLessThanOrEqualToTimestamp with endless WriteConflictException retries. @@ -337,7 +338,7 @@ public: * fail, say for correctness. */ virtual boost::optional<BSONObj> findOplogEntryLessThanOrEqualToTimestampRetryOnWCE( - OperationContext* opCtx, const Collection* oplog, const Timestamp& timestamp) = 0; + OperationContext* opCtx, const CollectionPtr& oplog, const Timestamp& timestamp) = 0; /** * Fetches the latest oplog entry's timestamp. Bypasses the oplog visibility rules. |