SERVER-43119 FailPoint cleanup

- Don't use MONGO_INITIALIZER to declare each fail point.
  We only need one init task in total: freeze and iterate the registry.

- remove MONGO_FAIL_POINT_DECLARE macro (extern)
- remove MONGO_FAIL_POINT_SHOULD_FAIL macro (FailPoint::shouldFail)
- remove MONGO_FAIL_POINT_BLOCK_IF (FailPoint::executeIf)
- remove MONGO_FAIL_POINT_BLOCK (FailPoint::execute)
- clean up FailPointRegistry and fail_point_service implementation.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/mongo/s/commands/document_shard_key_update_util.cpp b/src/mongo/s/commands/document_shard_key_update_util.cpp
index 119193d9ee5..90f12f4c8f5 100644
--- a/src/mongo/s/commands/document_shard_key_update_util.cpp
+++ b/src/mongo/s/commands/document_shard_key_update_util.cpp
@@ -77,9 +77,9 @@ bool executeOperationsAsPartOfShardKeyUpdate(OperationContext* opCtx,
         return false;
     }
 
-    if (MONGO_FAIL_POINT(hangBeforeInsertOnUpdateShardKey)) {
+    if (MONGO_unlikely(hangBeforeInsertOnUpdateShardKey.shouldFail())) {
         log() << "Hit hangBeforeInsertOnUpdateShardKey failpoint";
-        MONGO_FAIL_POINT_PAUSE_WHILE_SET_OR_INTERRUPTED(opCtx, hangBeforeInsertOnUpdateShardKey);
+        hangBeforeInsertOnUpdateShardKey.pauseWhileSet(opCtx);
     }
 
     auto insertOpMsg = OpMsgRequest::fromDBAndBody(db, insertCmdObj);