summaryrefslogtreecommitdiff
path: root/src/mongo/util/safe_num_test.cpp
diff options
context:
space:
mode:
authorBenety Goh <benety@mongodb.com>2021-08-19 08:50:38 -0400
committerEvergreen Agent <no-reply@evergreen.mongodb.com>2021-08-19 13:17:44 +0000
commitebf3af24d79133eddc61309d85f4267b69795d79 (patch)
treed714a4d922eec4f32771dc00e64f9d141de257d9 /src/mongo/util/safe_num_test.cpp
parentcbb527e1b930a4d55deb499312dce917cf491558 (diff)
downloadmongo-ebf3af24d79133eddc61309d85f4267b69795d79.tar.gz
SERVER-57633 fix implicit long long to double conversion in unit tests
Diffstat (limited to 'src/mongo/util/safe_num_test.cpp')
-rw-r--r--src/mongo/util/safe_num_test.cpp5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/mongo/util/safe_num_test.cpp b/src/mongo/util/safe_num_test.cpp
index 90e324cd3c3..5e1457d3b21 100644
--- a/src/mongo/util/safe_num_test.cpp
+++ b/src/mongo/util/safe_num_test.cpp
@@ -189,9 +189,10 @@ TEST(Addition, Overflow64toDouble) {
const SafeNum int64MinusOne(maxInt64 + -1);
ASSERT_EQUALS(int64MinusOne.type(), mongo::NumberLong);
- const SafeNum doubleResult(std::numeric_limits<int64_t>::max() + static_cast<double>(1));
+ const SafeNum doubleResult(static_cast<double>(std::numeric_limits<int64_t>::max()));
ASSERT_EQUALS(doubleResult.type(), mongo::NumberDouble);
ASSERT_NOT_EQUALS(int64PlusOne, doubleResult);
+ ASSERT_NOT_EQUALS(maxInt64, doubleResult);
}
TEST(Addition, OverflowDouble) {
@@ -474,7 +475,7 @@ TEST(Multiplication, Overflow64toDouble) {
const SafeNum int64TimesTwo(maxInt64 * 2);
ASSERT_EQUALS(int64TimesTwo.type(), mongo::EOO);
- const SafeNum doubleResult(std::numeric_limits<int64_t>::max() * static_cast<double>(2));
+ const SafeNum doubleResult(static_cast<double>(std::numeric_limits<int64_t>::max()) * 2);
ASSERT_EQUALS(doubleResult.type(), mongo::NumberDouble);
ASSERT_NOT_EQUALS(int64TimesTwo, doubleResult);
}