summaryrefslogtreecommitdiff
path: root/jstests/libs/override_methods
diff options
context:
space:
mode:
Diffstat (limited to 'jstests/libs/override_methods')
-rw-r--r--jstests/libs/override_methods/implicitly_retry_on_background_op_in_progress.js138
1 files changed, 138 insertions, 0 deletions
diff --git a/jstests/libs/override_methods/implicitly_retry_on_background_op_in_progress.js b/jstests/libs/override_methods/implicitly_retry_on_background_op_in_progress.js
new file mode 100644
index 00000000000..6018fba5755
--- /dev/null
+++ b/jstests/libs/override_methods/implicitly_retry_on_background_op_in_progress.js
@@ -0,0 +1,138 @@
+/**
+ * Overrides runCommand so operations that encounter the BackgroundOperationInProgressForNs/Db error
+ * codes automatically retry.
+ */
+(function() {
+ "use strict";
+
+ load("jstests/libs/override_methods/override_helpers.js");
+
+ // These are all commands that can return BackgroundOperationInProgress error codes.
+ const commandWhitelist = new Set([
+ "cloneCollectionAsCapped",
+ "collMod",
+ "compact",
+ "convertToCapped",
+ "createIndexes",
+ "drop",
+ "dropDatabase",
+ "dropIndexes",
+ "reIndex",
+ "renameCollection",
+ ]);
+
+ // Whitelisted errors commands may encounter when retried on a sharded cluster. Shards may
+ // return different responses, so errors associated with repeated executions of a command may be
+ // ignored.
+ const acceptableCommandErrors = {
+ "drop": [ErrorCodes.NamespaceNotFound],
+ "dropIndexes": [ErrorCodes.IndexNotFound],
+ "renameCollection": [ErrorCodes.NamespaceNotFound],
+ };
+
+ const kTimeout = 10 * 60 * 1000;
+ const kInterval = 200;
+
+ // Make it easier to understand whether or not returns from the assert.soon are being retried.
+ const kNoRetry = true;
+ const kRetry = false;
+
+ function hasBackgroundOpInProgress(res) {
+ // Only these are retryable.
+ return res.code === ErrorCodes.BackgroundOperationInProgressForNamespace ||
+ res.code === ErrorCodes.BackgroundOperationInProgressForDatabase;
+ }
+
+ function runCommandWithRetries(conn, dbName, commandName, commandObj, func, makeFuncArgs) {
+ if (typeof commandObj !== "object" || commandObj === null) {
+ return func.apply(conn, makeFuncArgs(commandObj));
+ }
+
+ let res;
+ let attempt = 0;
+
+ assert.soon(
+ () => {
+ attempt++;
+
+ res = func.apply(conn, makeFuncArgs(commandObj));
+ if (res.ok === 1) {
+ return kNoRetry;
+ }
+
+ // Commands that are not in the whitelist should never fail with this error code.
+ if (!commandWhitelist.has(commandName)) {
+ return kNoRetry;
+ }
+
+ let message = "Retrying the " + commandName +
+ " command because a background operation is in progress (attempt " + attempt +
+ ")";
+
+ // This handles the retry case when run against a standalone, replica set, or mongos
+ // where both shards returned the same response.
+ if (hasBackgroundOpInProgress(res)) {
+ print(message);
+ return kRetry;
+ }
+
+ // The following logic only applies to sharded clusters.
+ if (!conn.isMongos() || !res.raw) {
+ // We don't attempt to retry commands for which mongos doesn't expose the raw
+ // responses from the shards.
+ return kNoRetry;
+ }
+
+ // In certain cases, retrying a command on a sharded cluster may result in a
+ // scenario where one shard has executed the command and another still has a
+ // background operation in progress. Retry, ignoring whitelisted errors on a
+ // command-by-command basis.
+ let shardsWithBackgroundOps = [];
+
+ // If any shard has a background operation in progress and the other shards sent
+ // whitelisted errors after a first attempt, retry the entire command.
+ for (let shard in res.raw) {
+ let shardRes = res.raw[shard];
+ if (shardRes.ok) {
+ continue;
+ }
+
+ if (hasBackgroundOpInProgress(shardRes)) {
+ shardsWithBackgroundOps.push(shard);
+ continue;
+ }
+
+ // If any of the shards return an error that is not whitelisted or even if a
+ // whitelisted error is received on the first attempt, do not retry.
+ let acceptableErrors = acceptableCommandErrors[commandName] || [];
+ if (!acceptableErrors.includes(shardRes.code)) {
+ return kNoRetry;
+ }
+ // Whitelisted errors can only occur from running a command more than once, so
+ // it would be unexpected to receive an error on the first attempt.
+ if (attempt === 1) {
+ return kNoRetry;
+ }
+ }
+
+ // At this point, all shards have resulted in whitelisted errors resulting in
+ // retrying whitelisted commands. Fake a successful response.
+ if (shardsWithBackgroundOps.length === 0) {
+ print("done retrying " + commandName +
+ " command because all shards have responded with acceptable errors");
+ res.ok = 1;
+ return kNoRetry;
+ }
+
+ print(message + " on shards: " + tojson(shardsWithBackgroundOps));
+ return kRetry;
+ },
+ () => "Timed out while retrying command '" + tojson(commandObj) + "', response: " +
+ tojson(res),
+ kTimeout,
+ kInterval);
+ return res;
+ }
+
+ OverrideHelpers.overrideRunCommand(runCommandWithRetries);
+})();