1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
|
/**
* Tests the maxAwaitTimeMS and topologyVersion parameters of the hello command, and its aliases,
* isMaster and ismaster.
* @tags: [requires_replication]
*/
(function() {
"use strict";
load("jstests/libs/fail_point_util.js");
load("jstests/libs/parallel_shell_helpers.js");
// ErrorCodes
const kIDLParserComparisonError = 51024;
// runTest takes in the hello command or its aliases, isMaster and ismaster.
function runTest(db, cmd, logFailpoint) {
// Check the command response contains a topologyVersion even if maxAwaitTimeMS and
// topologyVersion are not included in the request.
const res = assert.commandWorked(db.runCommand(cmd));
assert(res.hasOwnProperty("topologyVersion"), tojson(res));
const topologyVersionField = res.topologyVersion;
assert(topologyVersionField.hasOwnProperty("processId"), tojson(topologyVersionField));
assert(topologyVersionField.hasOwnProperty("counter"), tojson(topologyVersionField));
// Check that the command succeeds when passed a valid topologyVersion and maxAwaitTimeMS. In
// this case, use the topologyVersion from the previous command response. The topologyVersion
// field is expected to be of the form {processId: <ObjectId>, counter: <long>}.
assert.commandWorked(
db.runCommand({[cmd]: 1, topologyVersion: topologyVersionField, maxAwaitTimeMS: 0}));
// Ensure the command waits for at least maxAwaitTimeMS before returning, and doesn't appear in
// slow query log even if it takes many seconds.
assert.commandWorked(db.adminCommand({clearLog: 'global'}));
let now = new Date();
jsTestLog(`Running slow ${cmd}`);
// Get the slow query log failpoint for the command, to know the current timesEntered before
// the command runs.
const timesEnteredBeforeRunningCommand = configureFailPoint(db, logFailpoint).timesEntered;
assert.commandWorked(
db.runCommand({[cmd]: 1, topologyVersion: topologyVersionField, maxAwaitTimeMS: 20000}));
let commandDuration = new Date() - now;
// Allow for some clock imprecision between the server and the jstest.
assert.gte(
commandDuration,
10000,
cmd + ` command should have taken at least 10000ms, but completed in ${commandDuration}ms`);
// Get the slow query log failpoint for the command, to make sure that it didn't get hit during
// the command run by checking that timesEntered is the same as before.
const timesEnteredAfterRunningCommand = configureFailPoint(db, logFailpoint).timesEntered;
assert(timesEnteredBeforeRunningCommand == timesEnteredAfterRunningCommand);
// Check that the command appears in the slow query log if it's unexpectedly slow.
function runHelloCommand(cmd, topologyVersionField) {
assert.commandWorked(
db.runCommand({[cmd]: 1, topologyVersion: topologyVersionField, maxAwaitTimeMS: 1}));
jsTestLog(`${cmd} completed in parallel shell`);
}
assert.commandWorked(db.adminCommand({clearLog: 'global'}));
// Use a skip of 1, since the parallel shell runs hello when it starts.
const helloFailpoint = configureFailPoint(db, "waitInHello", {}, {skip: 1});
const logFailPoint = configureFailPoint(db, logFailpoint);
const awaitHello = startParallelShell(funWithArgs(runHelloCommand, cmd, topologyVersionField),
db.getMongo().port);
helloFailpoint.wait();
sleep(1000); // Make the command hang for a second in the parallel shell.
helloFailpoint.off();
// Wait for the parallel shell to finish.
awaitHello();
// Wait for the command to be logged.
logFailPoint.wait();
// Check that when a different processId is given, the server responds immediately.
now = new Date();
assert.commandWorked(db.runCommand({
[cmd]: 1,
topologyVersion: {processId: ObjectId(), counter: topologyVersionField.counter},
maxAwaitTimeMS: 2000
}));
commandDuration = new Date() - now;
assert.lt(
commandDuration,
1000,
cmd + ` command should have taken at most 1000ms, but completed in ${commandDuration}ms`);
// Check that when a different processId is given, a higher counter is allowed.
assert.commandWorked(db.runCommand({
[cmd]: 1,
topologyVersion:
{processId: ObjectId(), counter: NumberLong(topologyVersionField.counter + 1)},
maxAwaitTimeMS: 0
}));
// Check that when the same processId is given, a higher counter is not allowed.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: {
processId: topologyVersionField.processId,
counter: NumberLong(topologyVersionField.counter + 1)
},
maxAwaitTimeMS: 0
}),
[31382, 51761, 51764]);
// Check that passing a topologyVersion not of type object fails.
assert.commandFailedWithCode(
db.runCommand({[cmd]: 1, topologyVersion: "topology_version_string", maxAwaitTimeMS: 0}),
ErrorCodes.TypeMismatch);
// Check that a topologyVersion with an invalid processId and valid counter fails.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: {processId: "pid1", counter: topologyVersionField.counter},
maxAwaitTimeMS: 0
}),
ErrorCodes.TypeMismatch);
// Check that a topologyVersion with a valid processId and invalid counter fails.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: {processId: topologyVersionField.processId, counter: 0},
maxAwaitTimeMS: 0
}),
ErrorCodes.TypeMismatch);
// Check that a topologyVersion with a valid processId but missing counter fails.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: {processId: topologyVersionField.processId},
maxAwaitTimeMS: 0
}),
40414);
// Check that a topologyVersion with a missing processId and valid counter fails.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: {counter: topologyVersionField.counter},
maxAwaitTimeMS: 0
}),
40414);
// Check that a topologyVersion with a valid processId and negative counter fails.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: {processId: topologyVersionField.processId, counter: NumberLong("-1")},
maxAwaitTimeMS: 0
}),
[31372, 51758]);
// Check that the command fails if there is an extra field in its topologyVersion.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: {
processId: topologyVersionField.processId,
counter: topologyVersionField.counter,
randomField: "I should cause an error"
},
maxAwaitTimeMS: 0
}),
40415);
// A client following the awaitable hello/isMaster protocol must include topologyVersion in
// their request if and only if they include maxAwaitTimeMS. Check that the command fails if
// there is a topologyVersion but no maxAwaitTimeMS field.
assert.commandFailedWithCode(db.runCommand({[cmd]: 1, topologyVersion: topologyVersionField}),
[31368, 51760]);
// Check that the command fails if there is a maxAwaitTimeMS field but no topologyVersion.
assert.commandFailedWithCode(db.runCommand({[cmd]: 1, maxAwaitTimeMS: 0}), [31368, 51760]);
// Check that the command fails if there is a valid topologyVersion but invalid maxAwaitTimeMS
// type.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: topologyVersionField,
maxAwaitTimeMS: "stringMaxAwaitTimeMS"
}),
ErrorCodes.TypeMismatch);
// Check that the command fails if there is a valid topologyVersion but negative maxAwaitTimeMS.
assert.commandFailedWithCode(db.runCommand({
[cmd]: 1,
topologyVersion: topologyVersionField,
maxAwaitTimeMS: -1,
}),
[31373, 51759, kIDLParserComparisonError]);
}
// Set command log verbosity to 0 to avoid logging *all* commands in the "slow query" log.
const conn = MongoRunner.runMongod({setParameter: {logComponentVerbosity: tojson({command: 0})}});
assert.neq(null, conn, "mongod was unable to start up");
runTest(conn.getDB("admin"), "hello", "waitForHelloCommandLogged");
runTest(conn.getDB("admin"), "isMaster", "waitForIsMasterCommandLogged");
runTest(conn.getDB("admin"), "ismaster", "waitForIsMasterCommandLogged");
MongoRunner.stopMongod(conn);
const replTest = new ReplSetTest(
{nodes: 1, nodeOptions: {setParameter: {logComponentVerbosity: tojson({command: 0})}}});
replTest.startSet();
replTest.initiate();
runTest(replTest.getPrimary().getDB("admin"), "hello", "waitForHelloCommandLogged");
runTest(replTest.getPrimary().getDB("admin"), "isMaster", "waitForIsMasterCommandLogged");
runTest(replTest.getPrimary().getDB("admin"), "ismaster", "waitForIsMasterCommandLogged");
replTest.stopSet();
const st = new ShardingTest({
mongos: 1,
shards: [{nodes: 1}],
config: 1,
other: {mongosOptions: {setParameter: {logComponentVerbosity: tojson({command: 0})}}}
});
runTest(st.s.getDB("admin"), "hello", "waitForHelloCommandLogged");
runTest(st.s.getDB("admin"), "isMaster", "waitForIsMasterCommandLogged");
runTest(st.s.getDB("admin"), "ismaster", "waitForIsMasterCommandLogged");
st.stop();
})();
|
