1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
|
/**
* Tests that read operations with readConcern majority only see committed data.
*
* The following read operations are tested:
* - find command
* - aggregation
* - distinct
* - group
* - count
* - parallelCollectionScan
* - geoNear
* - geoSearch
*
* Each operation is tested on a single node, and (if supported) through mongos on both sharded and
* unsharded collections. Mongos doesn't directly handle readConcern majority, but these tests
* should ensure that it correctly propagates the setting to the shards when running commands.
*/
(function() {
'use strict';
var testServer = MongoRunner.runMongod();
var db = testServer.getDB("test");
if (!db.serverStatus().storageEngine.supportsCommittedReads) {
print("Skipping read_majority.js since storageEngine doesn't support it.");
return;
}
MongoRunner.stopMongod(testServer);
function makeCursor(db, result) {
return new DBCommandCursor(db, result);
}
// These test cases are functions that return a cursor of the documents in collections without
// fetching them yet.
var cursorTestCases = {
find: function(coll) {
return makeCursor(coll.getDB(),
assert.commandWorked(coll.runCommand(
'find', {readConcern: {level: 'majority'}, batchSize: 0})));
},
aggregate: function(coll) {
return makeCursor(
coll.getDB(),
assert.commandWorked(coll.runCommand(
'aggregate',
{readConcern: {level: 'majority'}, cursor: {batchSize: 0}, pipeline: []})));
},
parallelCollectionScan: function(coll) {
var res = coll.runCommand('parallelCollectionScan',
{readConcern: {level: 'majority'}, numCursors: 1});
assert.commandWorked(res);
assert.eq(res.cursors.length, 1, tojson(res));
return makeCursor(coll.getDB(), res.cursors[0]);
},
};
// These test cases have a run method that will be passed a collection with a single object with
// _id: 1 and a state field that equals either "before" or "after". The collection will also
// contain both a 2dsphere and a geoHaystack index to enable testing commands that depend on
// them. The return value from the run method is expected to be the value of expectedBefore or
// expectedAfter depending on the state of the state field.
var nonCursorTestCases = {
count_before: {
run: function(coll) {
var res = coll.runCommand(
'count', {readConcern: {level: 'majority'}, query: {state: 'before'}});
assert.commandWorked(res);
return res.n;
},
expectedBefore: 1,
expectedAfter: 0,
},
count_after: {
run: function(coll) {
var res = coll.runCommand(
'count', {readConcern: {level: 'majority'}, query: {state: 'after'}});
assert.commandWorked(res);
return res.n;
},
expectedBefore: 0,
expectedAfter: 1,
},
distinct: {
run: function(coll) {
var res =
coll.runCommand('distinct', {readConcern: {level: 'majority'}, key: 'state'});
assert.commandWorked(res);
assert.eq(res.values.length, 1, tojson(res));
return res.values[0];
},
expectedBefore: 'before',
expectedAfter: 'after',
},
geoNear: {
run: function(coll) {
var res = coll.runCommand('geoNear', {
readConcern: {level: 'majority'},
near: [0, 0],
spherical: true,
});
assert.commandWorked(res);
assert.eq(res.results.length, 1, tojson(res));
return res.results[0].obj.state;
},
expectedBefore: 'before',
expectedAfter: 'after',
},
geoSearch: {
run: function(coll) {
var res = coll.runCommand('geoSearch', {
readConcern: {level: 'majority'},
near: [0, 0],
search: {_id: 1}, // Needed due to SERVER-23158.
maxDistance: 1,
});
assert.commandWorked(res);
assert.eq(res.results.length, 1, tojson(res));
return res.results[0].state;
},
expectedBefore: 'before',
expectedAfter: 'after',
},
group: {
run: function(coll) {
var res = coll.runCommand({
'group': {
ns: coll.getName(),
key: {_id: 1},
initial: {},
$reduce: function(curr, result) {
result.state = curr.state;
},
},
readConcern: {level: 'majority'},
});
assert.commandWorked(res);
assert.eq(res.retval.length, 1, tojson(res));
return res.retval[0].state;
},
expectedBefore: 'before',
expectedAfter: 'after',
},
};
function runTests(coll, mongodConnection) {
function makeSnapshot() {
return assert.commandWorked(mongodConnection.adminCommand("makeSnapshot")).name;
}
function setCommittedSnapshot(snapshot) {
assert.commandWorked(mongodConnection.adminCommand({"setCommittedSnapshot": snapshot}));
}
for (var testName in cursorTestCases) {
jsTestLog('Running ' + testName + ' against ' + coll.toString());
var getCursor = cursorTestCases[testName];
// Setup initial state.
assert.writeOK(coll.remove({}));
assert.writeOK(coll.save({_id: 1, state: 'before'}));
setCommittedSnapshot(makeSnapshot());
// Check initial conditions.
assert.eq(getCursor(coll).next().state, 'before');
// Change state without making it committed.
assert.writeOK(coll.save({_id: 1, state: 'after'}));
// Cursor still sees old state.
assert.eq(getCursor(coll).next().state, 'before');
// Create a cursor before the update is visible.
var oldCursor = getCursor(coll);
// Making a snapshot doesn't make the update visible yet.
var snapshot = makeSnapshot();
assert.eq(getCursor(coll).next().state, 'before');
// Setting it as committed does for both new and old cursors.
setCommittedSnapshot(snapshot);
assert.eq(getCursor(coll).next().state, 'after');
assert.eq(oldCursor.next().state, 'after');
}
assert.commandWorked(coll.ensureIndex({point: '2dsphere'}));
assert.commandWorked(coll.ensureIndex({point: 'geoHaystack', _id: 1}, {bucketSize: 1}));
for (var testName in nonCursorTestCases) {
jsTestLog('Running ' + testName + ' against ' + coll.toString());
var getResult = nonCursorTestCases[testName].run;
var expectedBefore = nonCursorTestCases[testName].expectedBefore;
var expectedAfter = nonCursorTestCases[testName].expectedAfter;
// Setup initial state.
assert.writeOK(coll.remove({}));
assert.writeOK(coll.save({_id: 1, state: 'before', point: [0, 0]}));
setCommittedSnapshot(makeSnapshot());
// Check initial conditions.
assert.eq(getResult(coll), expectedBefore);
// Change state without making it committed.
assert.writeOK(coll.save({_id: 1, state: 'after', point: [0, 0]}));
// Cursor still sees old state.
assert.eq(getResult(coll), expectedBefore);
// Making a snapshot doesn't make the update visible yet.
var snapshot = makeSnapshot();
assert.eq(getResult(coll), expectedBefore);
// Setting it as committed does.
setCommittedSnapshot(snapshot);
assert.eq(getResult(coll), expectedAfter);
}
}
var replTest = new ReplSetTest({
nodes: 1,
oplogSize: 2,
nodeOptions: {
setParameter: 'testingSnapshotBehaviorInIsolation=true',
enableMajorityReadConcern: '',
shardsvr: ''
}
});
replTest.startSet();
replTest.initiate();
var mongod = replTest.getPrimary();
(function testSingleNode() {
var db = mongod.getDB("singleNode");
runTests(db.collection, mongod);
})();
var shardingTest = new ShardingTest({
shards: 0,
mongos: 1,
});
assert(shardingTest.adminCommand({addShard: replTest.getURL()}));
// Remove tests of commands that aren't supported at all through mongos, even on unsharded
// collections.
['parallelCollectionScan', 'geoSearch'].forEach(function(cmd) {
// Make sure it really isn't supported.
assert.eq(shardingTest.getDB('test').coll.runCommand(cmd).code, ErrorCodes.CommandNotFound);
delete cursorTestCases[cmd];
delete nonCursorTestCases[cmd];
});
(function testUnshardedDBThroughMongos() {
var db = shardingTest.getDB("throughMongos");
runTests(db.unshardedDB, mongod);
})();
shardingTest.adminCommand({enableSharding: 'throughMongos'});
(function testUnshardedCollectionThroughMongos() {
var db = shardingTest.getDB("throughMongos");
runTests(db.unshardedCollection, mongod);
})();
(function testShardedCollectionThroughMongos() {
var db = shardingTest.getDB("throughMongos");
var collection = db.shardedCollection;
shardingTest.adminCommand({shardCollection: collection.getFullName(), key: {_id: 1}});
// The group command isn't supported on sharded collections. It also uses a weird syntax so
// code to check that it isn't supported can't be reused with other commands.
assert.eq(collection.runCommand({'group': {ns: collection.getName()}}).code,
ErrorCodes.IllegalOperation);
delete nonCursorTestCases.group;
runTests(collection, mongod);
})();
shardingTest.stop();
replTest.stopSet();
})();
|