summaryrefslogtreecommitdiff
path: root/jstests/sharding/retryable_writes.js
blob: f83c1b9cdc73243be581c12d76fc9e65328cbd18 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
/**
 * Test basic retryable write without errors by checking that the resulting collection after the
 * retry is as expected and it does not create additional oplog entries.
 */
(function() {
    "use strict";

    function checkFindAndModifyResult(expected, toCheck) {
        assert.eq(expected.ok, toCheck.ok);
        assert.eq(expected.value, toCheck.value);

        // TODO: SERVER-30532: after adding upserted, just compare the entire lastErrorObject
        var expectedLE = expected.lastErrorObject;
        var toCheckLE = toCheck.lastErrorObject;

        assert.neq(null, toCheckLE);
        assert.eq(expected.updatedExisting, toCheck.updatedExisting);
        assert.eq(expected.n, toCheck.n);
    }

    function runTests(mainConn, priConn) {
        var lsid = UUID();

        ////////////////////////////////////////////////////////////////////////
        // Test insert command

        var cmd = {
            insert: 'user',
            documents: [{_id: 10}, {_id: 30}],
            ordered: false,
            lsid: {id: lsid},
            txnNumber: NumberLong(34),
        };

        var testDBMain = mainConn.getDB('test');
        var result = assert.commandWorked(testDBMain.runCommand(cmd));

        var oplog = priConn.getDB('local').oplog.rs;
        var insertOplogEntries = oplog.find({ns: 'test.user', op: 'i'}).itcount();

        var testDBPri = priConn.getDB('test');
        assert.eq(2, testDBPri.user.find().itcount());

        var retryResult = assert.commandWorked(testDBMain.runCommand(cmd));
        assert.eq(result.ok, retryResult.ok);
        assert.eq(result.n, retryResult.n);
        assert.eq(result.writeErrors, retryResult.writeErrors);
        assert.eq(result.writeConcernErrors, retryResult.writeConcernErrors);

        assert.eq(2, testDBPri.user.find().itcount());
        assert.eq(insertOplogEntries, oplog.find({ns: 'test.user', op: 'i'}).itcount());

        ////////////////////////////////////////////////////////////////////////
        // Test update command

        cmd = {
            update: 'user',
            updates: [
                {q: {_id: 10}, u: {$inc: {x: 1}}},  // in place
                {q: {_id: 20}, u: {$inc: {y: 1}}, upsert: true},
                {q: {_id: 30}, u: {z: 1}}  // replacement
            ],
            ordered: false,
            lsid: {id: lsid},
            txnNumber: NumberLong(35),
        };

        result = assert.commandWorked(testDBMain.runCommand(cmd));

        let updateOplogEntries = oplog.find({ns: 'test.user', op: 'u'}).itcount();

        // Upserts are stored as inserts in the oplog, so check inserts too.
        insertOplogEntries = oplog.find({ns: 'test.user', op: 'i'}).itcount();

        assert.eq(3, testDBPri.user.find().itcount());

        retryResult = assert.commandWorked(testDBMain.runCommand(cmd));
        assert.eq(result.ok, retryResult.ok);
        assert.eq(result.n, retryResult.n);
        assert.eq(result.nModified, retryResult.nModified);
        assert.eq(result.upserted, retryResult.upserted);
        assert.eq(result.writeErrors, retryResult.writeErrors);
        assert.eq(result.writeConcernErrors, retryResult.writeConcernErrors);

        assert.eq(3, testDBPri.user.find().itcount());

        assert.eq({_id: 10, x: 1}, testDBPri.user.findOne({_id: 10}));
        assert.eq({_id: 20, y: 1}, testDBPri.user.findOne({_id: 20}));
        assert.eq({_id: 30, z: 1}, testDBPri.user.findOne({_id: 30}));

        assert.eq(updateOplogEntries, oplog.find({ns: 'test.user', op: 'u'}).itcount());
        assert.eq(insertOplogEntries, oplog.find({ns: 'test.user', op: 'i'}).itcount());

        ////////////////////////////////////////////////////////////////////////
        // Test delete command

        assert.writeOK(testDBMain.user.insert({_id: 40, x: 1}));
        assert.writeOK(testDBMain.user.insert({_id: 50, y: 1}));

        assert.eq(2, testDBPri.user.find({x: 1}).itcount());
        assert.eq(2, testDBPri.user.find({y: 1}).itcount());

        cmd = {
            delete: 'user',
            deletes: [{q: {x: 1}, limit: 1}, {q: {y: 1}, limit: 1}],
            ordered: false,
            lsid: {id: lsid},
            txnNumber: NumberLong(36),
        };

        result = assert.commandWorked(mainConn.getDB('test').runCommand(cmd));

        let deleteOplogEntries = oplog.find({ns: 'test.user', op: 'd'}).itcount();

        assert.eq(1, testDBPri.user.find({x: 1}).itcount());
        assert.eq(1, testDBPri.user.find({y: 1}).itcount());

        retryResult = assert.commandWorked(testDBMain.runCommand(cmd));
        assert.eq(result.ok, retryResult.ok);
        assert.eq(result.n, retryResult.n);
        assert.eq(result.writeErrors, retryResult.writeErrors);
        assert.eq(result.writeConcernErrors, retryResult.writeConcernErrors);

        assert.eq(1, testDBPri.user.find({x: 1}).itcount());
        assert.eq(1, testDBPri.user.find({y: 1}).itcount());

        assert.eq(deleteOplogEntries, oplog.find({ns: 'test.user', op: 'd'}).itcount());

        ////////////////////////////////////////////////////////////////////////
        // Test findAndModify command (upsert)

        cmd = {
            findAndModify: 'user',
            query: {_id: 60},
            update: {$inc: {x: 1}},
            new: true,
            upsert: true,
            lsid: {id: lsid},
            txnNumber: NumberLong(37),
        };

        result = assert.commandWorked(mainConn.getDB('test').runCommand(cmd));
        insertOplogEntries = oplog.find({ns: 'test.user', op: 'i'}).itcount();
        updateOplogEntries = oplog.find({ns: 'test.user', op: 'u'}).itcount();
        assert.eq({_id: 60, x: 1}, testDBPri.user.findOne({_id: 60}));

        retryResult = assert.commandWorked(testDBMain.runCommand(cmd));

        assert.eq({_id: 60, x: 1}, testDBPri.user.findOne({_id: 60}));
        assert.eq(insertOplogEntries, oplog.find({ns: 'test.user', op: 'i'}).itcount());
        assert.eq(updateOplogEntries, oplog.find({ns: 'test.user', op: 'u'}).itcount());

        checkFindAndModifyResult(result, retryResult);

        ////////////////////////////////////////////////////////////////////////
        // Test findAndModify command (update, return pre-image)

        cmd = {
            findAndModify: 'user',
            query: {_id: 60},
            update: {$inc: {x: 1}},
            new: false,
            upsert: false,
            lsid: {id: lsid},
            txnNumber: NumberLong(38),
        };

        result = assert.commandWorked(mainConn.getDB('test').runCommand(cmd));
        var oplogEntries = oplog.find({ns: 'test.user', op: 'u'}).itcount();
        assert.eq({_id: 60, x: 2}, testDBPri.user.findOne({_id: 60}));

        retryResult = assert.commandWorked(testDBMain.runCommand(cmd));

        assert.eq({_id: 60, x: 2}, testDBPri.user.findOne({_id: 60}));
        assert.eq(oplogEntries, oplog.find({ns: 'test.user', op: 'u'}).itcount());

        checkFindAndModifyResult(result, retryResult);

        ////////////////////////////////////////////////////////////////////////
        // Test findAndModify command (update, return post-image)

        cmd = {
            findAndModify: 'user',
            query: {_id: 60},
            update: {$inc: {x: 1}},
            new: true,
            upsert: false,
            lsid: {id: lsid},
            txnNumber: NumberLong(39),
        };

        result = assert.commandWorked(mainConn.getDB('test').runCommand(cmd));
        oplogEntries = oplog.find({ns: 'test.user', op: 'u'}).itcount();
        assert.eq({_id: 60, x: 3}, testDBPri.user.findOne({_id: 60}));

        retryResult = assert.commandWorked(testDBMain.runCommand(cmd));

        assert.eq({_id: 60, x: 3}, testDBPri.user.findOne({_id: 60}));
        assert.eq(oplogEntries, oplog.find({ns: 'test.user', op: 'u'}).itcount());

        checkFindAndModifyResult(result, retryResult);

        ////////////////////////////////////////////////////////////////////////
        // Test findAndModify command (remove, return pre-image)

        assert.writeOK(testDBMain.user.insert({_id: 70, f: 1}));
        assert.writeOK(testDBMain.user.insert({_id: 80, f: 1}));

        cmd = {
            findAndModify: 'user',
            query: {f: 1},
            remove: true,
            lsid: {id: lsid},
            txnNumber: NumberLong(40),
        };

        result = assert.commandWorked(mainConn.getDB('test').runCommand(cmd));
        oplogEntries = oplog.find({ns: 'test.user', op: 'd'}).itcount();
        var docCount = testDBPri.user.find().itcount();

        retryResult = assert.commandWorked(testDBMain.runCommand(cmd));

        assert.eq(oplogEntries, oplog.find({ns: 'test.user', op: 'd'}).itcount());
        assert.eq(docCount, testDBPri.user.find().itcount());

        checkFindAndModifyResult(result, retryResult);
    }

    function runFailpointTests(mainConn, priConn) {
        // Test the 'onPrimaryTransactionalWrite' failpoint
        var lsid = UUID();
        var testDb = mainConn.getDB('TestDB');

        // Test connection close (default behaviour). The connection will get closed, but the
        // inserts must succeed
        assert.commandWorked(priConn.adminCommand(
            {configureFailPoint: 'onPrimaryTransactionalWrite', mode: 'alwaysOn'}));

        try {
            // If ran against mongos, the command will actually succeed, but only one of the writes
            // would be executed. Set skipRetryOnNetworkError so the shell doesn't automatically
            // retry, since the command has a txnNumber.
            TestData.skipRetryOnNetworkError = true;
            var res = assert.commandWorked(testDb.runCommand({
                insert: 'user',
                documents: [{x: 0}, {x: 1}],
                ordered: true,
                lsid: {id: lsid},
                txnNumber: NumberLong(1)
            }));
            assert.eq(0, res.n);
            assert.eq(1, res.writeErrors.length);
        } catch (e) {
            var exceptionMsg = e.toString();
            assert(isNetworkError(e), 'Incorrect exception thrown: ' + exceptionMsg);
        } finally {
            TestData.skipRetryOnNetworkError = false;
        }

        assert.eq(2, testDb.user.find({}).itcount());

        // Test exception throw. One update must succeed and the other must fail.
        assert.commandWorked(priConn.adminCommand({
            configureFailPoint: 'onPrimaryTransactionalWrite',
            mode: {skip: 1},
            data: {
                closeConnection: false,
                failBeforeCommitExceptionCode: ErrorCodes.InternalError
            }
        }));

        var cmd = {
            update: 'user',
            updates: [{q: {x: 0}, u: {$inc: {y: 1}}}, {q: {x: 1}, u: {$inc: {y: 1}}}],
            ordered: true,
            lsid: {id: lsid},
            txnNumber: NumberLong(2)
        };

        var writeResult = testDb.runCommand(cmd);

        assert.eq(1, writeResult.nModified);
        assert.eq(1, writeResult.writeErrors.length);
        assert.eq(1, writeResult.writeErrors[0].index);
        assert.eq(ErrorCodes.InternalError, writeResult.writeErrors[0].code);

        assert.commandWorked(
            priConn.adminCommand({configureFailPoint: 'onPrimaryTransactionalWrite', mode: 'off'}));

        var writeResult = testDb.runCommand(cmd);
        assert.eq(2, writeResult.nModified);

        var collContents = testDb.user.find({}).sort({x: 1}).toArray();
        assert.eq(2, collContents.length);
        assert.eq(0, collContents[0].x);
        assert.eq(1, collContents[0].y);
        assert.eq(1, collContents[1].x);
        assert.eq(1, collContents[1].y);
    }

    function runMultiTests(mainConn, priConn) {
        // Test the behavior of retryable writes with multi=true / limit=0
        var lsid = {id: UUID()};
        var testDb = mainConn.getDB('test_multi');

        // Only the update statements with multi=true in a batch fail.
        var cmd = {
            update: 'user',
            updates: [{q: {x: 1}, u: {y: 1}}, {q: {x: 2}, u: {z: 1}, multi: true}],
            ordered: true,
            lsid: lsid,
            txnNumber: NumberLong(1),
        };
        var res = assert.commandWorked(testDb.runCommand(cmd));
        assert.eq(1,
                  res.writeErrors.length,
                  'expected only one write error, received: ' + tojson(res.writeErrors));
        assert.eq(1,
                  res.writeErrors[0].index,
                  'expected the update at index 1 to fail, not the update at index: ' +
                      res.writeErrors[0].index);
        assert.eq(ErrorCodes.InvalidOptions,
                  res.writeErrors[0].code,
                  'expected to fail with code ' + ErrorCodes.InvalidOptions + ', received: ' +
                      res.writeErrors[0].code);

        // Only the delete statements with limit=0 in a batch fail.
        cmd = {
            delete: 'user',
            deletes: [{q: {x: 1}, limit: 1}, {q: {y: 1}, limit: 0}],
            ordered: false,
            lsid: lsid,
            txnNumber: NumberLong(1),
        };
        res = assert.commandWorked(testDb.runCommand(cmd));
        assert.eq(1,
                  res.writeErrors.length,
                  'expected only one write error, received: ' + tojson(res.writeErrors));
        assert.eq(1,
                  res.writeErrors[0].index,
                  'expected the delete at index 1 to fail, not the delete at index: ' +
                      res.writeErrors[0].index);
        assert.eq(ErrorCodes.InvalidOptions,
                  res.writeErrors[0].code,
                  'expected to fail with code ' + ErrorCodes.InvalidOptions + ', received: ' +
                      res.writeErrors[0].code);
    }

    // Tests for replica set
    var replTest = new ReplSetTest({nodes: 2});
    replTest.startSet();
    replTest.initiate();

    var priConn = replTest.getPrimary();

    runTests(priConn, priConn);
    runFailpointTests(priConn, priConn);
    runMultiTests(priConn, priConn);

    replTest.stopSet();

    // Tests for sharded cluster
    var st = new ShardingTest({shards: {rs0: {nodes: 1}}});

    runTests(st.s0, st.rs0.getPrimary());
    runFailpointTests(st.s0, st.rs0.getPrimary());
    runMultiTests(st.s0, st.rs0.getPrimary());

    st.stop();
})();