summaryrefslogtreecommitdiff
path: root/src/strtofr.c
diff options
context:
space:
mode:
authorvlefevre <vlefevre@280ebfd0-de03-0410-8827-d642c229c3f4>2018-04-27 11:17:16 +0000
committervlefevre <vlefevre@280ebfd0-de03-0410-8827-d642c229c3f4>2018-04-27 11:17:16 +0000
commit4e5c5dbc93a6125a34ed66b4545765b6b6f330c1 (patch)
tree0e3d010ed192216ec51a9d8e01a7fd9a292defa1 /src/strtofr.c
parent92ea516b34199e52e20f898d36a41eb26abc57e2 (diff)
downloadmpfr-4e5c5dbc93a6125a34ed66b4545765b6b6f330c1.tar.gz
[src/strtofr.c] Added a TODO about potentially unnecessary code.
git-svn-id: svn://scm.gforge.inria.fr/svn/mpfr/trunk@12686 280ebfd0-de03-0410-8827-d642c229c3f4
Diffstat (limited to 'src/strtofr.c')
-rw-r--r--src/strtofr.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/strtofr.c b/src/strtofr.c
index 9856b2131..9c76862b0 100644
--- a/src/strtofr.c
+++ b/src/strtofr.c
@@ -680,6 +680,14 @@ parsed_string_to_mpfr (mpfr_t x, struct parsed_string *pstr, mpfr_rnd_t rnd)
err = mpfr_mpn_exp (z, &exp_z, pstr->base, exp_z, ysize);
/* Since we want y/z rounded toward zero, we must get an upper
bound on z. If err >= 0, the error on z is bounded by 2^err. */
+ /* TODO: Is this necessary? If this has an effect on the
+ rounded result, doesn't this mean that mpfr_round_p will
+ catch the error and yield a Ziv loop?
+ Disabling this code by adding "0 &&" in front of "err >= 0"
+ with r12685 does not yield any "make check" failure for both
+ the 32-bit and the 64-bit ABI's.
+ If this code is unnecessary, this would also mean that r12573
+ actually did not fix anything. */
if (err >= 0)
{
mp_limb_t cy;