diff options
author | António Fernandes <antoniof@gnome.org> | 2022-09-07 11:24:36 +0100 |
---|---|---|
committer | António Fernandes <antoniof@gnome.org> | 2022-10-22 11:33:51 +0000 |
commit | 42648767773b2df1a27108c211e1779e33564d7d (patch) | |
tree | 4f2b5b8e16dad72f12dc0c24557adb91520b0239 | |
parent | 2159f1e45c688130318132ebf3880d29f5a8518b (diff) | |
download | nautilus-42648767773b2df1a27108c211e1779e33564d7d.tar.gz |
image-properties: Actually show failure info
We ask to append a failure message with NULL value, and then don't
actually append it because of the value being NULL. This makes no
sense, so fix it.
Despite that, in order to improve visuals, move the failure message
to the value and use an existing generic error string as title.
-rw-r--r-- | extensions/image-properties/nautilus-image-properties-model.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/extensions/image-properties/nautilus-image-properties-model.c b/extensions/image-properties/nautilus-image-properties-model.c index 24e579bda..930a910e9 100644 --- a/extensions/image-properties/nautilus-image-properties-model.c +++ b/extensions/image-properties/nautilus-image-properties-model.c @@ -64,10 +64,7 @@ append_item (NautilusImagesPropertiesModel *self, g_autoptr (NautilusPropertiesItem) item = NULL; item = nautilus_properties_item_new (name, value); - if (value != NULL) - { - g_list_store_append (self->group_model, item); - } + g_list_store_append (self->group_model, item); } static void @@ -240,7 +237,7 @@ load_finished (NautilusImagesPropertiesModel *self) } else { - append_item (self, _("Failed to load image information"), NULL); + append_item (self, _("Oops! Something went wrong."), _("Failed to load image information")); } if (self->loader != NULL) |