| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Currently, the type list box in the search popover is not
keyboard-navigable, which, as a consequence, results in the user’s
inability to also easily close the popover.
https://bugzilla.gnome.org/show_bug.cgi?id=786402
|
| | |
|
| |
|
|
|
|
|
|
| |
Opening the file properties window causes a crash with images that have
embedded XMP information. This is caused by not initializing the library
properly.
https://bugzilla.gnome.org/show_bug.cgi?id=785292
|
| |
|
|
|
|
|
|
| |
When marking the file as gone, clearing its file info after removing it
from the parent directory will result in a crash in cases where it is
the last reference being dropped.
https://bugzilla.gnome.org/show_bug.cgi?id=785562
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
This was causing problems for Launchpad's translation importer
for Ubuntu.
"Line 7166: Unsupported plural case number."
|
| |
|
|
|
|
|
|
| |
Opening the batch rename dialog and immediately closing it results in a
crash, due to the async operation not being canceled, thus resulting in
invalid memory access on callback.
https://bugzilla.gnome.org/show_bug.cgi?id=784336
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wayland allows multiple pointers to be active at the same time, e.g. when
a Wacom tablet and mouse are both connected to a system. This means that
it is possible to recieve a "rubberband start" event from a second tool
while a rubberband is already active. At the moment, this results in stray
selection rectangles since the canvas does not properly perform cleanup.
To prevent these graphical glitches from occuring, we can simply cancel
any existing rubberband operation if a second one attempts to start. The
only additional minor complication is ensuring that the new rubberband
is not stopped when the first tool sends a button-up event.
https://bugzilla.gnome.org/show_bug.cgi?id=783797
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nautilus assumes that the pointer returned by gdk_seat_get_pointer will
return the same GdkDevice which started a rubberband action. This is
not necessarily the case, however. Under Wayland, for example, tablet
tools have pointers (and GdkDevice's) which are entirely separate from
the seat's primary mouse-driven pointer. Attempting to use a pen to
perform rubberband selection will result in the rectangle being drawn
with the incorrect coordinates.
This patch has the code store the GdkDevice which generated the event
and provides it in place of the call to gdk_seat_get_pointer.
https://bugzilla.gnome.org/show_bug.cgi?id=783797
|
| | |
|
| |
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=782601
|
| |
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=782601
|
| |
|
|
|
|
|
|
|
|
| |
When undo_active/redo_active is FALSE, undo_label/redo_label
was getting overwritten irrespective of whether they were
NULL or not.
Let the label values be freed incase they are updated.
https://bugzilla.gnome.org/show_bug.cgi?id=782083
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Nautilus allowed line wrapping for filenames after a . or _
The code made an exception for version numbers, but it
was too rigid and broke things like Ubuntu's 12.04 version
numbering. This relaxes the exception so that the line isn't
wrapped for a . or _ immediately followed by any numbers.
https://launchpad.net/bugs/942539
https://bugzilla.gnome.org/show_bug.cgi?id=781875
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue is that when pressing enter in search while the search entry
has the focus, right after the callback to activate the selection is
called, Nautilus also tries to activate the location corresponding to
the base of the search, as the view is still searching.
This occurs because in the activated signal the search is set as not
visible manually, which will make Nautilus check immediatly if it should
go back to the base of the search location, without waiting for the view
to update.
To fix this, don't set the search as not visible in the activated callback,
as when the search-mode-enabled property changes, if necessarry, the
cancel signal will be emitted which will set the search as not visible,
which will happen only after the view is updated. This is the behavior for
activating the selection in other ways, so activation with focus on the
entry should behave the same.
https://bugzilla.gnome.org/show_bug.cgi?id=764981
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The problem is that when we have a file conflict dialog, we can write
a new name for the file in GtkEntry in the expander "Select a new
name for the destination", but after typing in a new file name,
pressing <ENTER> does nothing, but should close this dialog and
confirm the renaming.
To fix this we enable "activates-default" flag for the GtkEntry.
https://bugzilla.gnome.org/show_bug.cgi?id=780449
|
| |
|
|
|
|
|
|
|
|
| |
nautilus_file_get_mime_type() returns a newly
allocated string, which should be freed when no longer
required.
using g_autofree() automatically frees the string fixing the leak
https://bugzilla.gnome.org/show_bug.cgi?id=782070
|
| |
|
|
|
|
|
|
| |
This hides the autostart from Ubuntu's Startup Applications
app since we don't want users to easily disable this without
understanding why it's there.
https://bugzilla.gnome.org/show_bug.cgi?id=781874
|
| | |
|
| |
|
|
|
| |
A comment from Alex said in there it was obsolete, and seems at some
point we reactivated it.
|
| |
|
|
|
|
| |
This reverts commit cc9511bb18975dde0ea806395d02b8e60176923f.
Also breaks string freeze
|
| |
|
|
|
|
|
|
| |
link"
This reverts commit b881c990337624ee511710b32b8ccff9269a5597.
It broke string freeze
|
| | |
|
| |
|
|
| |
We were pulling from gtk4 branch which will make the code to not work.
|
| |
|
|
|
|
|
|
|
| |
We were prepending the items but in regular order, instead of inverse
to preserve the order.
To fix it the patch invert the order of the items when prepending.
https://bugzilla.gnome.org/show_bug.cgi?id=774724
|
| |
|
|
|
|
|
| |
Currently, the flow view tries to reveal the selection even if it is
empty. That can result in a crash if the selection is empty.
https://bugzilla.gnome.org/show_bug.cgi?id=780732
|
| |
|
|
|
|
| |
It is no longer used as of 8b26778710510c9a1d3e7aa8ea82d4dfd7c4a3e9.
https://bugzilla.gnome.org/show_bug.cgi?id=780730
|
| |
|
|
|
|
| |
A copy paste error from the set_items function.
https://bugzilla.gnome.org/show_bug.cgi?id=780380
|
| |
|
|
|
|
| |
It was missing in the new GtkFlowBox based view.
https://bugzilla.gnome.org/show_bug.cgi?id=780380
|
| |
|
|
|
|
|
|
| |
Items are not allocated at that time yet, so it needs some time to be
able to calculate the correct allocation of the item, and therefore the
correct adjustment for the scrolled window.
https://bugzilla.gnome.org/show_bug.cgi?id=780380
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Until now we weren't selecting the item that was selected.
However it really helps to do that so the user can navigate after
searching. For instance this is pretty good to have for the "type-ahead"
use case.
This commit select the file after the user opens the item location
and reveals the file.
https://bugzilla.gnome.org/show_bug.cgi?id=780380
|
| |
|
|
| |
Forgot to delete it after coding :(
|
| |
|
|
|
| |
It's not longer necessary. This patch removes it and also fixes
a compiler warning.
|
| |
|
|
|
|
|
|
| |
So users can drag the window from the buttons of the pathbar too, as it
seems it's more important feature for them instead of dnd the path in
the pathbar, which is also quite undiscoverable.
https://bugzilla.gnome.org/show_bug.cgi?id=776663
|
| |
|
|
|
|
|
|
|
| |
Currently, the extraction starts without checking
for enough filesystem space to store the extracted files.
This commit checks for filespace before the extraction takes place.
https://bugzilla.gnome.org/show_bug.cgi?id=775253
|
| |
|
|
|
|
|
|
|
|
| |
Currently when the move to/copy to file chooser dialog is launched
during search, the dialog shows an error as the location is invalid.
Change this so that the base of the search is displayed in the dialog
when this dialog is launched while searching.
https://bugzilla.gnome.org/show_bug.cgi?id=778113
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With a batch renaming using a template, the extension is removed.
That is, if we have a file named "some.txt", after renaming using
template "[Original file name]YOLO" we will get "someYOLO.txt",
and this is correct.
But if we renaming folders with a name where there is a dot and
subsequent symbols, these characters will be mistakenly considered
an extension. For example, after renaming folders "file" -> "fileYOLO",
"FILEZ." -> "FILEZ.YOLO" (is correct), but "org.package.library" ->
"org.packageYOLO.library", "project-2.0" -> "project-2YOLO.0",
"my.files" -> "myYOLO.files", "extra-0.85" -> "extra-0YOLO.85" (is
incorrect)
To fix this bug we won't search extension if current NautilusFile
is a directory.
https://bugzilla.gnome.org/show_bug.cgi?id=780326
|
| |
|
|
|
|
|
|
|
|
|
| |
If the user tries to replace a folder with a symbolic link with the same
name,the content of the destination folder was being deleted.
To fix this behaviour, the UI disables the replace button allowing the
user only to skip or to rename in order to avoid the deletion of the
destination folder's content.
https://bugzilla.gnome.org/show_bug.cgi?id=632323
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
GtkPlacesView now supports monitoring networks.
|
