summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormvglasow <michael -at- vonglasow.com>2021-01-24 17:56:02 +0200
committermvglasow <michael -at- vonglasow.com>2021-01-24 17:56:02 +0200
commit3aaab0aa1788a660604ae26a5f794f8bbde67337 (patch)
tree35c8d6072825facd383c9ed6833ac4c027b7381d
parent97669fb71f3be71e58ec26bc548f66d07df2ed37 (diff)
downloadnavit-traff_0_8.tar.gz
Refactor:traffic/traff_android:remove TODO commenttraff_0_8
Signed-off-by: mvglasow <michael -at- vonglasow.com>
-rw-r--r--navit/android/src/org/navitproject/navit/NavitTraff.java10
1 files changed, 8 insertions, 2 deletions
diff --git a/navit/android/src/org/navitproject/navit/NavitTraff.java b/navit/android/src/org/navitproject/navit/NavitTraff.java
index 621ad39a9..fd499b70b 100644
--- a/navit/android/src/org/navitproject/navit/NavitTraff.java
+++ b/navit/android/src/org/navitproject/navit/NavitTraff.java
@@ -220,8 +220,14 @@ public class NavitTraff extends BroadcastReceiver {
} else {
/* 0.7 feed */
String packageName = intent.getStringExtra(EXTRA_PACKAGE);
- /* if the feed comes from a TraFF 0.8+ source and we are subscribed, skip it */
- // TODO what if we don’t have a subscription yet? First subscribe, then poll (still no guarantee)
+ /*
+ * If the feed comes from a TraFF 0.8+ source and we are subscribed, skip it.
+ * As a side effect of the current implementation, if a “bilingual” TraFF 0.7/0.8
+ * source sends a broadcast feed before we have subscribed to it, we would process
+ * the whole feed first, and then subscribe to a subset of that data.
+ * If that turns out to be an issue, we would need to detect TraFF 0.8-capable
+ * sources and discard broadcast feeds from them.
+ */
if ((packageName != null) && subscriptions.containsValue(packageName))
return;
String feed = intent.getStringExtra(EXTRA_FEED);