summaryrefslogtreecommitdiff
path: root/checkstyle.xml
diff options
context:
space:
mode:
authorCharles Curley <charlescurley@users.noreply.github.com>2018-08-30 00:08:15 -0600
committerPierre GRANDIN <pgrandin@users.noreply.github.com>2018-08-29 23:08:15 -0700
commit751676252e813ab32196f48763d103314125cfb9 (patch)
treea8da846cbcd5d199e95db4e98e11fa611d716af2 /checkstyle.xml
parentb52b58f8931c81b4d36677405780eac25835d803 (diff)
downloadnavit-751676252e813ab32196f48763d103314125cfb9.tar.gz
Curley distance poi (#638)
* 1) Changed the translation string for "Distance(m)" from "" to "Distance". Rational: the "m" is ambiguous, it could be meters or miles. However, in the POI context, feet are more likely than miles. So take it out entirely. I did it this way rather than run sed on the entire collection of po input files. 2) The display code sorts the entries by distance. It has no way of knowing if "5" is five miles or five feet. So we leave the distances in feet or meters (depending on the setting for imperial). Allowing kilometers or miles might be a future enhancement. 3) See bug 556 (https://github.com/navit-gps/navit/issues/556). Rather than remove the spurious one as part of this fix, I will leave that to later. But both now have the same English "translation", "Select a search radius from screen center". This hides the problem, at least from English users. This affects all four en_*.po.in files. 4) Someone who knows more than I do about the translation strings might have a better idea. Particularly, is there a graceful way to indicate the input units, either miles or kilometers? modified: navit/gui/gtk/gui_gtk_poi.c modified: po/en.po.in modified: po/en_AU.po.in modified: po/en_CA.po.in modified: po/en_GB.po.in * Made it prettier. Reformatted one commented and tabified the thing. modified: navit/gui/gtk/gui_gtk_poi.c * Replaced one of the two source strings for the PoI window prompt for inputting the search radius. Pull Request 557. modified: navit/gui/gtk/gui_gtk_poi.c modified: po/af.po.in modified: po/ar.po.in modified: po/ast.po.in modified: po/be.po.in modified: po/bg.po.in modified: po/bs.po.in modified: po/ca.po.in modified: po/ckb.po.in modified: po/cs.po.in modified: po/cy.po.in modified: po/da.po.in modified: po/de.po.in modified: po/de_CH.po.in modified: po/el.po.in modified: po/en.po.in modified: po/en_AU.po.in modified: po/en_CA.po.in modified: po/en_GB.po.in modified: po/eo.po.in modified: po/es.po.in modified: po/et.po.in modified: po/eu.po.in modified: po/fa.po.in modified: po/fi.po.in modified: po/fil.po.in modified: po/fo.po.in modified: po/fr.po.in modified: po/fr_CH.po.in modified: po/fy.po.in modified: po/gl.po.in modified: po/he.po.in modified: po/hi.po.in modified: po/hr.po.in modified: po/hu.po.in modified: po/id.po.in modified: po/it.po.in modified: po/ja.po.in modified: po/jv.po.in modified: po/kk.po.in modified: po/kn.po.in modified: po/ko.po.in modified: po/ku.po.in modified: po/lb.po.in modified: po/lt.po.in modified: po/lv.po.in modified: po/mk.po.in modified: po/ml.po.in modified: po/mn.po.in modified: po/mr.po.in modified: po/nb.po.in modified: po/nds.po.in modified: po/nl.po.in modified: po/nn.po.in modified: po/pl.po.in modified: po/pms.po.in modified: po/pt.po.in modified: po/pt_BR.po.in modified: po/ro.po.in modified: po/ru.po.in modified: po/sc.po.in modified: po/si.po.in modified: po/sk.po.in modified: po/sl.po.in modified: po/sq.po.in modified: po/sr.po.in modified: po/sv.po.in modified: po/sw.po.in modified: po/ta.po.in modified: po/te.po.in modified: po/th.po.in modified: po/tr.po.in modified: po/uk.po.in modified: po/ur.po.in modified: po/vi.po.in modified: po/zh_CN.po.in modified: po/zh_HK.po.in modified: po/zh_TW.po.in * The distance to points of interest has been rendered in kilometers even if the user has asked for imperial. This commit fixes that. We convert to feet only, and not miles, because the code sorts on the numeric value of the distance, so it doesn't like two different units. Currently, the distance is an int. Can it be made a float? Possible future enhancement? modified: navit/gui/gtk/gui_gtk_poi.c * Improved comment. modified: navit/gui/gtk/gui_gtk_poi.c
Diffstat (limited to 'checkstyle.xml')
0 files changed, 0 insertions, 0 deletions