summaryrefslogtreecommitdiff
path: root/navit/binding
diff options
context:
space:
mode:
authormvglasow <michael -at- vonglasow.com>2018-08-16 21:18:18 +0200
committermvglasow <michael -at- vonglasow.com>2018-08-16 21:18:18 +0200
commit5fd76ac19a256ef7e3b6dc3d724800505f9cc7fd (patch)
treeacaa7db2a2fd506e4322c75dece32bdd5f43b803 /navit/binding
parentd7087d97f3542b8e3dbf46c442a3d20c65b5cb0d (diff)
downloadnavit-5fd76ac19a256ef7e3b6dc3d724800505f9cc7fd.tar.gz
Refactor:binding/dbus:attr on heap in request_navit_traffic_export_gpx()
Signed-off-by: mvglasow <michael -at- vonglasow.com>
Diffstat (limited to 'navit/binding')
-rw-r--r--navit/binding/dbus/binding_dbus.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/navit/binding/dbus/binding_dbus.c b/navit/binding/dbus/binding_dbus.c
index ad9dddd5f..ea79c0591 100644
--- a/navit/binding/dbus/binding_dbus.c
+++ b/navit/binding/dbus/binding_dbus.c
@@ -1212,7 +1212,7 @@ static DBusHandlerResult request_navit_traffic_export_gpx(DBusConnection *connec
char * filename;
struct navit * navit;
DBusMessageIter iter;
- struct attr * attr;
+ struct attr attr;
struct attr_iter * a_iter;
struct traffic * traffic = NULL;
FILE *fp;
@@ -1242,12 +1242,10 @@ static DBusHandlerResult request_navit_traffic_export_gpx(DBusConnection *connec
dbus_message_iter_get_basic(&iter, &filename);
- attr = g_new0(struct attr, 1);
a_iter = navit_attr_iter_new();
- if (navit_get_attr(navit, attr_traffic, attr, a_iter))
- traffic = (struct traffic *) attr->u.navit_object;
+ if (navit_get_attr(navit, attr_traffic, &attr, a_iter))
+ traffic = (struct traffic *) attr.u.navit_object;
navit_attr_iter_destroy(a_iter);
- g_free(attr);
if (!traffic)
return dbus_error_traffic_not_configured(connection, message);