diff options
author | Neil Brown <neilb@suse.de> | 2006-06-23 14:38:33 +1000 |
---|---|---|
committer | Neil Brown <neilb@suse.de> | 2006-06-23 14:38:33 +1000 |
commit | 2e075a16da4963f54cd556403ca9e15a68de27fd (patch) | |
tree | 5e412d94ec623315a93286af4da52a2883dcd0a4 /support/misc | |
parent | ff42180930a444cea7f19e55e2cd2bfe6d3f108b (diff) | |
download | nfs-utils-2e075a16da4963f54cd556403ca9e15a68de27fd.tar.gz |
Fix various issues discovered by Coverity
Thanks to Michael Halcrow for finding them.
Diffstat (limited to 'support/misc')
-rw-r--r-- | support/misc/mountpoint.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/support/misc/mountpoint.c b/support/misc/mountpoint.c index 6d0f34e..2cf1324 100644 --- a/support/misc/mountpoint.c +++ b/support/misc/mountpoint.c @@ -20,15 +20,21 @@ is_mountpoint(char *path) */ char *dotdot; struct stat stb, pstb; + int rv; dotdot = malloc(strlen(path)+4); + if (!dotdot) + return 0; strcat(strcpy(dotdot, path), "/.."); if (lstat(path, &stb) != 0 || lstat(dotdot, &pstb) != 0) - return 0; - - if (stb.st_dev != pstb.st_dev - || stb.st_ino == pstb.st_ino) - return 1; - return 0; + rv = 0; + else + if (stb.st_dev != pstb.st_dev || + stb.st_ino == pstb.st_ino) + rv = 1; + else + rv = 0; + free(dotdot); + return rv; } |