diff options
| author | Marco Ippolito <marcoippolito54@gmail.com> | 2023-03-25 09:24:55 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-25 08:24:55 +0000 |
| commit | a64469dcf10adb81fdc5b1e5248ce58520858761 (patch) | |
| tree | abbc22c60343059b8aff7ac023362b7e7191aa96 /.github/workflows | |
| parent | 5e4f5e122c06744967f539def1e51473abb5db62 (diff) | |
| download | node-new-a64469dcf10adb81fdc5b1e5248ce58520858761.tar.gz | |
tools: standardize update-nghttp2.sh
PR-URL: https://github.com/nodejs/node/pull/47197
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/tools.yml | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml index 5e286f98f7..c8fbd5b4ed 100644 --- a/.github/workflows/tools.yml +++ b/.github/workflows/tools.yml @@ -142,12 +142,10 @@ jobs: subsystem: deps label: dependencies run: | - NEW_VERSION=$(gh api repos/nghttp2/nghttp2/releases/latest -q '.tag_name|ltrimstr("v")') - CURRENT_VERSION=$(grep "#define NGHTTP2_VERSION" ./deps/nghttp2/lib/includes/nghttp2/nghttp2ver.h | sed -n "s/^.*VERSION \(.*\)/\1/p") - if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then - echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV - ./tools/update-nghttp2.sh "$NEW_VERSION" - fi + ./tools/dep_updaters/nghttp2.sh > temp-output + cat temp-output + tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true + rm temp-output - id: llhttp subsystem: deps label: dependencies |