summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-12-26 13:21:57 +0100
committerAnna Henningsen <anna@addaleax.net>2018-12-30 19:37:52 +0100
commite2faf8c82aa2fd8b4d86c673c39afecd4179073e (patch)
tree968212bf4858af82aa6153d28190e151a110a523
parent97d8bc854164604b8f46ce1ef3370d9335dbdbd7 (diff)
downloadnode-new-v6.x-staging.tar.gz
test: fix test-repl-envvarsv6.x-staging
In 180f86507d496b11aa35b2df4594629a92cce329, the test was changed so that the `env` argument of `createInternalRepl()` also contained external environment variables, because keeping them can be necessary for spawning processes on some systems. However, this test does not spawn new processes, and relies on the fact that the environment variables it tests are not already set (and fails otherwise); therefore, reverting to the original state should fix this. Fixes: https://github.com/nodejs/node/issues/21451 Fixes: https://github.com/nodejs/build/issues/1377 Refs: https://github.com/nodejs/node/pull/25219 PR-URL: https://github.com/nodejs/node/pull/25226 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
-rw-r--r--test/parallel/test-repl-envvars.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/test/parallel/test-repl-envvars.js b/test/parallel/test-repl-envvars.js
index c0b1f53b3c..5f597e0abb 100644
--- a/test/parallel/test-repl-envvars.js
+++ b/test/parallel/test-repl-envvars.js
@@ -36,7 +36,7 @@ const tests = [
];
function run(test) {
- const env = Object.assign({}, process.env, test.env);
+ const env = test.env;
const expected = test.expected;
const opts = {
terminal: true,