diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-12-31 19:12:00 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-01-03 10:25:59 -0800 |
| commit | 7e15f0490a894607ee1cedbe02026793a0f589e5 (patch) | |
| tree | bb2b00339c8755b8b851de05df809d3e2371572c | |
| parent | aea52299f7e5d234020145a87d89127bb8f1dfdb (diff) | |
| download | node-new-7e15f0490a894607ee1cedbe02026793a0f589e5.tar.gz | |
lib,test: remove lib/internal/test/unicode.js
Remove lib/internal/test/unicode.js and associated test. When we added
the file and test, only comments in lib had non-ASCII characters. Now,
lib/internal/cli_table.js has non-ASCII characters. Tests that exercise
the `console.table()` therefore fulfill the need to test non-ASCII
characters in built-in modules.
PR-URL: https://github.com/nodejs/node/pull/25298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | lib/internal/cli_table.js | 6 | ||||
| -rw-r--r-- | lib/internal/test/unicode.js | 8 | ||||
| -rw-r--r-- | node.gyp | 1 | ||||
| -rw-r--r-- | test/parallel/test-internal-unicode.js | 12 |
4 files changed, 6 insertions, 21 deletions
diff --git a/lib/internal/cli_table.js b/lib/internal/cli_table.js index f6c711ece8..71d322ee9e 100644 --- a/lib/internal/cli_table.js +++ b/lib/internal/cli_table.js @@ -4,6 +4,12 @@ const { Buffer } = require('buffer'); const { removeColors } = require('internal/util'); const HasOwnProperty = Function.call.bind(Object.prototype.hasOwnProperty); +// The use of Unicode characters below is the only non-comment use of non-ASCII +// Unicode characters in Node.js built-in modules. If they are ever removed or +// rewritten with \u escapes, then a test will need to be (re-)added to Node.js +// core to verify that Unicode characters work in built-ins. Otherwise, +// consumers using Unicode in _third_party_main.js will run into problems. +// Refs: https://github.com/nodejs/node/issues/10673 const tableChars = { /* eslint-disable node-core/non-ascii-character */ middleMiddle: '─', diff --git a/lib/internal/test/unicode.js b/lib/internal/test/unicode.js deleted file mode 100644 index 451c3c4737..0000000000 --- a/lib/internal/test/unicode.js +++ /dev/null @@ -1,8 +0,0 @@ -'use strict'; - -// This module exists entirely for regression testing purposes. -// See `test/parallel/test-internal-unicode.js`. - -/* eslint-disable node-core/non-ascii-character */ -module.exports = '✓'; -/* eslint-enable node-core/non-ascii-character */ @@ -161,7 +161,6 @@ 'lib/internal/socket_list.js', 'lib/internal/test/binding.js', 'lib/internal/test/heap.js', - 'lib/internal/test/unicode.js', 'lib/internal/timers.js', 'lib/internal/tls.js', 'lib/internal/trace_events_async_hooks.js', diff --git a/test/parallel/test-internal-unicode.js b/test/parallel/test-internal-unicode.js deleted file mode 100644 index 0a36309c09..0000000000 --- a/test/parallel/test-internal-unicode.js +++ /dev/null @@ -1,12 +0,0 @@ -'use strict'; -require('../common'); - -// Flags: --expose-internals -// -// This test ensures that UTF-8 characters can be used in core JavaScript -// libraries built into Node's binary. - -const assert = require('assert'); -const character = require('internal/test/unicode'); - -assert.strictEqual(character, '✓'); |