summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Nagy <ronagy@icloud.com>2020-02-11 18:32:33 +0100
committerShelley Vohr <shelley.vohr@gmail.com>2020-02-17 12:48:36 -0800
commit825d08976386099121932d790d44eff1f159b668 (patch)
treeab9f9104240e2d1bf93afc9080598deb1ecf206d
parent2de085fe9367f95bfea0f7bea1cd7a8b19a0e196 (diff)
downloadnode-new-825d08976386099121932d790d44eff1f159b668.tar.gz
crypto: fix performance regression
https://github.com/nodejs/node/commit/e559842188f541b884abff2ffad4d2d3e1b841a6 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: https://github.com/nodejs/node/issues/31739 PR-URL: https://github.com/nodejs/node/pull/31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
-rw-r--r--lib/internal/streams/lazy_transform.js2
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/internal/streams/lazy_transform.js b/lib/internal/streams/lazy_transform.js
index 6584159095..69bba428af 100644
--- a/lib/internal/streams/lazy_transform.js
+++ b/lib/internal/streams/lazy_transform.js
@@ -19,8 +19,6 @@ module.exports = LazyTransform;
function LazyTransform(options) {
this._options = options;
- this.writable = true;
- this.readable = true;
}
ObjectSetPrototypeOf(LazyTransform.prototype, stream.Transform.prototype);
ObjectSetPrototypeOf(LazyTransform, stream.Transform);