diff options
author | sivaprasanna <sivaprasanna@gmail.com> | 2016-12-30 11:01:03 +0530 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2017-01-06 09:49:54 -0800 |
commit | 8839d504cca2f404ff50842e9451a1a8a0ff28a0 (patch) | |
tree | 0ce00c1310c0759cba29903d4227573203347f75 | |
parent | c1b12a2896329017cd8f91c4384e5a7b9f372ba3 (diff) | |
download | node-new-8839d504cca2f404ff50842e9451a1a8a0ff28a0.tar.gz |
test: refactor the code in test-util-debug.js
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed unwanted console log
PR-URL: https://github.com/nodejs/node/pull/10531
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-rw-r--r-- | test/sequential/test-util-debug.js | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/test/sequential/test-util-debug.js b/test/sequential/test-util-debug.js index c0e15c1436..08988997e7 100644 --- a/test/sequential/test-util-debug.js +++ b/test/sequential/test-util-debug.js @@ -17,44 +17,43 @@ function parent() { } function test(environ, shouldWrite) { - var expectErr = ''; + let expectErr = ''; if (shouldWrite) { expectErr = 'TUD %PID%: this { is: \'a\' } /debugging/\n' + 'TUD %PID%: number=1234 string=asdf obj={"foo":"bar"}\n'; } - var expectOut = 'ok\n'; + const expectOut = 'ok\n'; const spawn = require('child_process').spawn; - var child = spawn(process.execPath, [__filename, 'child'], { + const child = spawn(process.execPath, [__filename, 'child'], { env: Object.assign(process.env, { NODE_DEBUG: environ }) }); expectErr = expectErr.split('%PID%').join(child.pid); - var err = ''; + let err = ''; child.stderr.setEncoding('utf8'); - child.stderr.on('data', function(c) { + child.stderr.on('data', (c) => { err += c; }); - var out = ''; + let out = ''; child.stdout.setEncoding('utf8'); - child.stdout.on('data', function(c) { + child.stdout.on('data', (c) => { out += c; }); - child.on('close', common.mustCall(function(c) { + child.on('close', common.mustCall((c) => { assert(!c); - assert.equal(err, expectErr); - assert.equal(out, expectOut); - console.log('ok %j %j', environ, shouldWrite); + assert.strictEqual(err, expectErr); + assert.strictEqual(out, expectOut); })); } function child() { const util = require('util'); - var debug = util.debuglog('tud'); + const debug = util.debuglog('tud'); debug('this', { is: 'a' }, /debugging/); debug('number=%d string=%s obj=%j', 1234, 'asdf', { foo: 'bar' }); console.log('ok'); |