diff options
author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2017-06-22 22:34:55 +0300 |
---|---|---|
committer | Myles Borins <mylesborins@google.com> | 2017-07-11 17:43:49 +0100 |
commit | 8860117600dfaf5cf6450cf702edcee5700759e0 (patch) | |
tree | 4ad26223ffc2d55f16a67ca4592858c11f72f0d0 | |
parent | f92e065d120c03a8bfc67dbdc3be69755cbc2422 (diff) | |
download | node-new-8860117600dfaf5cf6450cf702edcee5700759e0.tar.gz |
addons: remove semicolons from after module definition
Having semicolons there runs counter to our documentation and illicits
warnings in pedantic mode. This removes semicolons from after uses of
NODE_MODULE and NODE_MODULE_CONTEXT_AWARE_BUILTIN.
PR-URL: https://github.com/nodejs/node/pull/12919
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
-rw-r--r-- | benchmark/misc/function_call/binding.cc | 2 | ||||
-rw-r--r-- | doc/api/addons.md | 2 | ||||
-rw-r--r-- | src/node_contextify.cc | 2 | ||||
-rw-r--r-- | test/addons/async-hello-world/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/at-exit/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/buffer-free-callback/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/hello-world-function-export/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/hello-world/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/load-long-path/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/null-buffer-neuter/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/parse-encoding/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/repl-domain-abort/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/stringbytes-external-exceed-max/binding.cc | 2 | ||||
-rw-r--r-- | test/addons/symlinked-module/binding.cc | 2 |
14 files changed, 14 insertions, 14 deletions
diff --git a/benchmark/misc/function_call/binding.cc b/benchmark/misc/function_call/binding.cc index c6718e8e33..9008f6c437 100644 --- a/benchmark/misc/function_call/binding.cc +++ b/benchmark/misc/function_call/binding.cc @@ -14,4 +14,4 @@ extern "C" void init (Local<Object> target) { NODE_SET_METHOD(target, "hello", Hello); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/doc/api/addons.md b/doc/api/addons.md index 58f029fb20..4d29b718ab 100644 --- a/doc/api/addons.md +++ b/doc/api/addons.md @@ -1096,7 +1096,7 @@ void init(Local<Object> exports) { AtExit(at_exit_cb1, exports->GetIsolate()); } -NODE_MODULE(addon, init); +NODE_MODULE(addon, init) } // namespace demo ``` diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 1ea8fa0b1c..1ec8774f24 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -980,4 +980,4 @@ void InitContextify(Local<Object> target, } // namespace node -NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify); +NODE_MODULE_CONTEXT_AWARE_BUILTIN(contextify, node::InitContextify) diff --git a/test/addons/async-hello-world/binding.cc b/test/addons/async-hello-world/binding.cc index e6033fc4fd..70fee63aa5 100644 --- a/test/addons/async-hello-world/binding.cc +++ b/test/addons/async-hello-world/binding.cc @@ -77,4 +77,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) { NODE_SET_METHOD(module, "exports", Method); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/at-exit/binding.cc b/test/addons/at-exit/binding.cc index 8f9d0b461c..c9b26a348a 100644 --- a/test/addons/at-exit/binding.cc +++ b/test/addons/at-exit/binding.cc @@ -40,4 +40,4 @@ void init(Local<Object> exports) { atexit(sanity_check); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/buffer-free-callback/binding.cc b/test/addons/buffer-free-callback/binding.cc index 5c95f594e7..24b5dea602 100644 --- a/test/addons/buffer-free-callback/binding.cc +++ b/test/addons/buffer-free-callback/binding.cc @@ -41,4 +41,4 @@ void init(v8::Local<v8::Object> exports) { NODE_SET_METHOD(exports, "check", Check); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/hello-world-function-export/binding.cc b/test/addons/hello-world-function-export/binding.cc index fa2cbc59a0..c113e0489b 100644 --- a/test/addons/hello-world-function-export/binding.cc +++ b/test/addons/hello-world-function-export/binding.cc @@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports, v8::Local<v8::Object> module) { NODE_SET_METHOD(module, "exports", Method); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/hello-world/binding.cc b/test/addons/hello-world/binding.cc index 8a8145f016..5651dc8f50 100644 --- a/test/addons/hello-world/binding.cc +++ b/test/addons/hello-world/binding.cc @@ -11,4 +11,4 @@ void init(v8::Local<v8::Object> exports) { NODE_SET_METHOD(exports, "hello", Method); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/load-long-path/binding.cc b/test/addons/load-long-path/binding.cc index 1cdcb4c200..83823ae836 100644 --- a/test/addons/load-long-path/binding.cc +++ b/test/addons/load-long-path/binding.cc @@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) { NODE_SET_METHOD(exports, "hello", Method); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/null-buffer-neuter/binding.cc b/test/addons/null-buffer-neuter/binding.cc index d0f26d4cc5..0d3d850304 100644 --- a/test/addons/null-buffer-neuter/binding.cc +++ b/test/addons/null-buffer-neuter/binding.cc @@ -38,4 +38,4 @@ void init(v8::Local<v8::Object> exports) { NODE_SET_METHOD(exports, "run", Run); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/parse-encoding/binding.cc b/test/addons/parse-encoding/binding.cc index 5c56d97fc6..65dba5b673 100644 --- a/test/addons/parse-encoding/binding.cc +++ b/test/addons/parse-encoding/binding.cc @@ -35,4 +35,4 @@ void Initialize(v8::Local<v8::Object> exports) { } // anonymous namespace -NODE_MODULE(binding, Initialize); +NODE_MODULE(binding, Initialize) diff --git a/test/addons/repl-domain-abort/binding.cc b/test/addons/repl-domain-abort/binding.cc index e7415c317f..a507b6fd01 100644 --- a/test/addons/repl-domain-abort/binding.cc +++ b/test/addons/repl-domain-abort/binding.cc @@ -23,4 +23,4 @@ void init(Local<Object> exports) { NODE_SET_METHOD(exports, "method", Method); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/stringbytes-external-exceed-max/binding.cc b/test/addons/stringbytes-external-exceed-max/binding.cc index 03fa29f273..2141d2c5b9 100644 --- a/test/addons/stringbytes-external-exceed-max/binding.cc +++ b/test/addons/stringbytes-external-exceed-max/binding.cc @@ -21,4 +21,4 @@ void init(v8::Local<v8::Object> exports) { NODE_SET_METHOD(exports, "ensureAllocation", EnsureAllocation); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) diff --git a/test/addons/symlinked-module/binding.cc b/test/addons/symlinked-module/binding.cc index 1cdcb4c200..83823ae836 100644 --- a/test/addons/symlinked-module/binding.cc +++ b/test/addons/symlinked-module/binding.cc @@ -10,4 +10,4 @@ void init(v8::Local<v8::Object> exports) { NODE_SET_METHOD(exports, "hello", Method); } -NODE_MODULE(binding, init); +NODE_MODULE(binding, init) |