diff options
| author | Gibson Fahnestock <gib@uk.ibm.com> | 2017-01-16 16:25:00 +0000 |
|---|---|---|
| committer | Gibson Fahnestock <gib@uk.ibm.com> | 2017-01-21 12:00:54 +0000 |
| commit | 93c482045859531e4983bb5481a151ac56b72161 (patch) | |
| tree | 189cf0ec8537ecd30f731ad4000e03891168dd68 | |
| parent | 492163c74cf8ed5bf581231a348d75e61809b9a2 (diff) | |
| download | node-new-93c482045859531e4983bb5481a151ac56b72161.tar.gz | |
Revert "doc: correct vcbuild options for windows testing"
This reverts commit ed9b6c1264a07084e44f1d269bfe82e0f1b37c74.
PR-URL: https://github.com/nodejs/node/pull/10839
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
| -rw-r--r-- | BUILDING.md | 8 | ||||
| -rw-r--r-- | CONTRIBUTING.md | 6 |
2 files changed, 7 insertions, 7 deletions
diff --git a/BUILDING.md b/BUILDING.md index b2a245acbd..a28759e1c7 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -122,7 +122,7 @@ Prerequisites: To run the tests: ```console -> .\vcbuild nosign test +> .\vcbuild test ``` To test if Node.js was built correctly: @@ -180,7 +180,7 @@ $ ./configure --with-intl=full-icu --download=all ##### Windows: ```console -> .\vcbuild nosign full-icu download-all +> .\vcbuild full-icu download-all ``` #### Building without Intl support @@ -197,7 +197,7 @@ $ ./configure --without-intl ##### Windows: ```console -> .\vcbuild nosign without-intl +> .\vcbuild without-intl ``` #### Use existing installed ICU (Unix / OS X only): @@ -240,7 +240,7 @@ First unpack latest ICU to `deps/icu` as `deps/icu` (You'll have: `deps/icu/source/...`) ```console -> .\vcbuild nosign full-icu +> .\vcbuild full-icu ``` ## Building Node.js with FIPS-compliant OpenSSL diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 736a9542c4..c60eeb1c6e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -170,7 +170,7 @@ $ ./configure && make -j4 test Windows: ```text - .\vcbuild nosign test +> vcbuild test ``` (See the [BUILDING.md](./BUILDING.md) for more details.) @@ -178,11 +178,11 @@ Windows: Make sure the linter is happy and that all tests pass. Please, do not submit patches that fail either check. -Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or +Running `make test`/`vcbuild test` will run the linter as well unless one or more tests fail. If you want to run the linter without running tests, use -`make lint`/`.\vcbuild nosign jslint`. +`make lint`/`vcbuild jslint`. If you are updating tests and just want to run a single test to check it, you can use this syntax to run it exactly as the test harness would: |