src: remove NodeCategorySet destructor

This currently crashes during environment cleanup because
the object would be torn down while there are enabled categories.

I’m not sure about the exact semantics here, but since the
object cannot be garbage collected at this point anyway
because it’s `Persistent` handle is strong, removing the
destructor at least doesn’t make anything worse than it is
right now (i.e. the destructor would never have been called
before anyway).

PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

1 files changed, 0 insertions, 5 deletions

diff --git a/src/node_trace_events.cc b/src/node_trace_events.cc
index 0c0699f7be..363d046de1 100644
--- a/src/node_trace_events.cc
+++ b/src/node_trace_events.cc
@@ -21,11 +21,6 @@ using v8::Value;
 
 class NodeCategorySet : public BaseObject {
  public:
-  ~NodeCategorySet() override {
-    // Verify that the thing was properly disabled before gc
-    CHECK_NE(enabled_, true);
-  }
-
   static void New(const FunctionCallbackInfo<Value>& args);
   static void Enable(const FunctionCallbackInfo<Value>& args);
   static void Disable(const FunctionCallbackInfo<Value>& args);