diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-03-07 19:49:22 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-03-09 22:25:19 -0800 |
| commit | b4e24e3c96ef404815cb232f4e3e7b87629477a1 (patch) | |
| tree | a26b769282f85d4b7f90990e7b67c9791d2c938d /COLLABORATOR_GUIDE.md | |
| parent | 6e81a959d0b1d23ecc0ae96ce969da8192ad60f9 (diff) | |
| download | node-new-b4e24e3c96ef404815cb232f4e3e7b87629477a1.tar.gz | |
doc: remove tsc-review
The tsc-review label is ineffective. It almost always gets ignored.
Remove it. When requiring TSC attention, people should @-mention the
TSC GitHub team.
PR-URL: https://github.com/nodejs/node/pull/26506
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index a14aaaa049..5f25ca0ff3 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -305,7 +305,6 @@ in the placeholder's `README`. For pull requests introducing new core modules: * Allow at least one week for review. -* Label with the `tsc-review` label. * Land only after sign-off from at least two TSC members. * Land with a [Stability Index][] of Experimental. The module must remain Experimental until a semver-major release. @@ -381,9 +380,8 @@ Do this if a pull request or issue: - is controversial, or - is at an impasse among Collaborators who are participating in the discussion. -Assign the `tsc-review` label or @-mention the -`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. -Do not use the GitHub UI on the right-hand side to assign to +@-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the +[TSC][]. Do not use the GitHub UI on the right-hand side to assign to `@nodejs/tsc` or request a review from `@nodejs/tsc`. The TSC should serve as the final arbiter where required. |