diff options
| author | Fedor Indutny <fedor@indutny.com> | 2018-11-29 22:01:33 -0500 |
|---|---|---|
| committer | Fedor Indutny <fedor@indutny.com> | 2018-12-02 12:51:32 -0500 |
| commit | 175164e5d12829b46f91137a01dac72f236a37be (patch) | |
| tree | 1751ba025ea989ea4260c4cf18f684729260b2b0 /CONTRIBUTING.md | |
| parent | 3fb627bead14e68d989b0f141226c1703fa062ca (diff) | |
| download | node-new-175164e5d12829b46f91137a01dac72f236a37be.tar.gz | |
http: fix error return in `Finish()`
`http_parser_execute(..., nullptr, 0)` returns either `0` or `1`. The
expectation is that no error must be returned if it is `0`, and if
it is `1` - a `Error` object must be returned back to user.
The introduction of `llhttp` and the refactor that happened during it
accidentally removed the error-returning code. This commit reverts it
back to its original state.
Fix: #24585
PR-URL: https://github.com/nodejs/node/pull/24738
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions