diff options
| author | Richard Lau <rlau@redhat.com> | 2021-06-09 11:27:25 -0400 |
|---|---|---|
| committer | Node.js GitHub Bot <github-bot@iojs.org> | 2021-06-11 18:11:48 +0000 |
| commit | 889ad35d3d41e376870f785b0c1b669cb732013d (patch) | |
| tree | 67e348a0df13e36b46888ef9b8cbafa8a7fa23b0 /Makefile | |
| parent | d615aeb7583b15bb5a8d1ec666ea29b8c7377455 (diff) | |
| download | node-new-889ad35d3d41e376870f785b0c1b669cb732013d.tar.gz | |
build: make build-addons errors fail the build
The `build-addons` makefile target runs `tools/doc/addon-verify.js` and
then uses `touch` to update a timestamp file. Unconditionally calling
`touch` was losing the exit code from `tools/doc/addon-verify.js` so
any errors produced by that script were not failing the build.
PR-URL: https://github.com/nodejs/node/pull/38983
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -352,7 +352,7 @@ test/addons/.docbuildstamp: $(DOCBUILDSTAMP_PREREQS) tools/doc/node_modules else \ $(RM) -r test/addons/??_*/; \ [ -x $(NODE) ] && $(NODE) $< || node $< ; \ - touch $@; \ + [ $$? -eq 0 ] && touch $@; \ fi ADDONS_BINDING_GYPS := \ |