diff options
author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2020-11-17 16:43:59 -0800 |
---|---|---|
committer | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2020-11-19 19:01:38 -0800 |
commit | 39e4d82c70318863150b811425fba9de1957b5cf (patch) | |
tree | a40d6c95fc234597502c9127d87d0178a16709d8 /benchmark | |
parent | efbec85f30d8d1bf0688dcf11198820b8f275d2c (diff) | |
download | node-new-39e4d82c70318863150b811425fba9de1957b5cf.tar.gz |
benchmark: fix build warnings
The napi/* benchmarks were using an incorrect signature for the V8
add-on init function. This was causing a warning.
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: https://github.com/nodejs/node/pull/36157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Diffstat (limited to 'benchmark')
-rw-r--r-- | benchmark/napi/function_args/binding.cc | 4 | ||||
-rw-r--r-- | benchmark/napi/function_call/binding.cc | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/benchmark/napi/function_args/binding.cc b/benchmark/napi/function_args/binding.cc index 2c54dd424d..078fe0ee3e 100644 --- a/benchmark/napi/function_args/binding.cc +++ b/benchmark/napi/function_args/binding.cc @@ -123,7 +123,9 @@ void CallWithArguments(const FunctionCallbackInfo<Value>& args) { } } -void Initialize(Local<Object> target) { +void Initialize(Local<Object> target, + Local<Value> module, + void* data) { NODE_SET_METHOD(target, "callWithString", CallWithString); NODE_SET_METHOD(target, "callWithLongString", CallWithString); diff --git a/benchmark/napi/function_call/binding.cc b/benchmark/napi/function_call/binding.cc index 289a94ac3e..570f96f41e 100644 --- a/benchmark/napi/function_call/binding.cc +++ b/benchmark/napi/function_call/binding.cc @@ -7,7 +7,9 @@ void Hello(const v8::FunctionCallbackInfo<v8::Value>& args) { args.GetReturnValue().Set(c++); } -void Initialize(v8::Local<v8::Object> target) { +void Initialize(v8::Local<v8::Object> target, + v8::Local<v8::Value> module, + void* data) { NODE_SET_METHOD(target, "hello", Hello); } |