diff options
| author | Yang Guo <yangguo@chromium.org> | 2018-11-20 08:59:38 +0100 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2018-11-24 12:02:13 +0100 |
| commit | 70e2f9db13e6e7fd845f5329b76782906a50ce02 (patch) | |
| tree | f702851563b7616f011d3c2943653f7aa77009ac /common.gypi | |
| parent | 9fe02af79425ae455e888ce2b99f86448d0053e6 (diff) | |
| download | node-new-70e2f9db13e6e7fd845f5329b76782906a50ce02.tar.gz | |
deps: cherry-pick 88f8fe1 from upstream V8
Original commit message:
Fix collection iterator preview with deleted entries
We used to assume that we know the remaining entries returned by the
iterator based on the current index. However, that is not accurate,
since entries skipped by the current index could be deleted.
In the new approach, we allocate conservatively and shrink the result.
R=neis@chromium.org
Bug: v8:8433
Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8
Reviewed-on: https://chromium-review.googlesource.com/c/1325966
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57360}
Refs: https://github.com/v8/v8/commit/88f8fe19a863c6392bd296faf86c06eff2a41bc1
PR-URL: https://github.com/nodejs/node/pull/24514
Refs: https://github.com/nodejs/node/issues/24053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 363eefb9a6..5a5a071832 100644 --- a/common.gypi +++ b/common.gypi @@ -31,7 +31,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.12', + 'v8_embedder_string': '-node.13', # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, |