diff options
| author | Michaël Zasso <targos@protonmail.com> | 2022-09-25 17:35:13 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2022-10-11 07:26:59 +0200 |
| commit | 88ed027d573fd3a98c4e927166903d369f474df2 (patch) | |
| tree | 421745e1196e6a3e632a25ac239cd155405cfb53 /common.gypi | |
| parent | 26c651c34e65558bbfb850a1a1b7f2e922dcbea9 (diff) | |
| download | node-new-88ed027d573fd3a98c4e927166903d369f474df2.tar.gz | |
deps: V8: cherry-pick 7ddb8399f9f1
Original commit message:
[msvc] fix ambiguous call to function in assembler test
MSVC is confused by initializer list and default parameter, and reports
an ambiguous call.
test/cctest/test-assembler-arm64.cc(12208): error C2668: 'v8::internal::Clobber': ambiguous call to overloaded function
test-utils-arm64.h(251): note: could be 'void v8::internal::Clobber(v8::internal::MacroAssembler *,v8::internal::CPURegList)'
test-utils-arm64.h(241): note: or 'void v8::internal::Clobber(v8::internal::MacroAssembler *,v8::internal::RegList,const uint64_t)'
Solution is to construct with explicit type.
Bug: v8:13312
Change-Id: I66f5ba48bcdf6eb30035beaf7214a3d26fc9f18b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3913034
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83406}
Refs: https://github.com/v8/v8/commit/7ddb8399f9f1aa2d703bffa9cc26fa94a7b3a0ef
PR-URL: https://github.com/nodejs/node/pull/44741
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 05b7429103..e5d973abda 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.9', + 'v8_embedder_string': '-node.10', ##### V8 defaults for Node.js ##### |