diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2022-09-08 19:52:10 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-08 17:52:10 +0000 |
| commit | 8a15f32d07c8fbb50528d37447ae296dd785f8eb (patch) | |
| tree | 199731494d067379b256fdf7c57f79d5fd36a965 /common.gypi | |
| parent | 50ad9fe9294bd177d349f8feb0c5a27689e5b5c1 (diff) | |
| download | node-new-8a15f32d07c8fbb50528d37447ae296dd785f8eb.tar.gz | |
Revert "build: go faster, drop -fno-omit-frame-pointer"
This reverts commit d0f73d383d5e1ed58c96a272036744d4bed22b8f.
The lack of frame pointers unfortunately breaks the --perf_basic_prof
flag because perf(1) then no longer understands C++ <-> JS stack frame
transitions.
PR-URL: https://github.com/nodejs/node/pull/44566
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 2a8beb34c1..3f708d89b1 100644 --- a/common.gypi +++ b/common.gypi @@ -204,7 +204,6 @@ ], }], ['OS=="solaris"', { - 'cflags': [ '-fno-omit-frame-pointer' ], # pull in V8's postmortem metadata 'ldflags': [ '-Wl,-z,allextract' ] }], @@ -212,6 +211,12 @@ # increase performance, number from experimentation 'cflags': [ '-qINLINE=::150:100000' ] }], + ['OS!="mac" and OS!="win" and OS!="zos"', { + # -fno-omit-frame-pointer is necessary for the --perf_basic_prof + # flag to work correctly. perf(1) gets confused about JS stack + # frames otherwise, even with --call-graph dwarf. + 'cflags': [ '-fno-omit-frame-pointer' ], + }], ['OS=="linux"', { 'conditions': [ ['enable_pgo_generate=="true"', { |