diff options
| author | Ali Ijaz Sheikh <ofrobots@google.com> | 2018-08-03 16:22:31 -0700 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2018-09-04 14:24:20 +0200 |
| commit | ec285c8c6697e2b415addd81fddafd81980f8b2c (patch) | |
| tree | 50e06e572fdc0616b97ee9840f3e30cefb885ab3 /common.gypi | |
| parent | c0fb95d700574a369988f3379559f66dba57404c (diff) | |
| download | node-new-ec285c8c6697e2b415addd81fddafd81980f8b2c.tar.gz | |
deps: cherry-pick bf5ea81 from upstream V8
Original commit message:
[tracing] allow dynamic control of tracing
If the trace_buffer_ was null, we were returning a pointer to a static
flag back that permanently disabled that particular trace point.
This implied an assumption that tracing will be statically enabled at
process startup, and once it is disabled, it will never be enabled
again. On Node.js side we want to dynamically enable/disable tracing as per
programmer intent.
Change-Id: Ic7a7839b8450ab5c356d85e8e0826f42824907f4
Reviewed-on: https://chromium-review.googlesource.com/1161518
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com>
Cr-Commit-Position: refs/heads/master@{#54903}
Refs: https://github.com/v8/v8/commit/bf5ea8138c0726613c9d722a3ccb552a8f477992
PR-URL: https://github.com/nodejs/node/pull/22114
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index 52e5d65480..5b744ad879 100644 --- a/common.gypi +++ b/common.gypi @@ -29,7 +29,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.23', + 'v8_embedder_string': '-node.24', # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, |