diff options
| author | Ali Ijaz Sheikh <ofrobots@google.com> | 2016-04-07 14:06:55 -0700 |
|---|---|---|
| committer | Ali Ijaz Sheikh <ofrobots@google.com> | 2016-04-14 10:03:39 -0700 |
| commit | 52af5c4eebf4de8638aef0338bd826656312a02a (patch) | |
| tree | 628dc9fb0b558c3a73a2160706fef368876fe548 /deps/v8/src/compiler/access-info.cc | |
| parent | 6e3e8acc7cc7ebd3d67db5ade1247b8b558efe09 (diff) | |
| download | node-new-52af5c4eebf4de8638aef0338bd826656312a02a.tar.gz | |
deps: upgrade V8 to 5.0.71.32
* Pick up the branch head for V8 5.0 stable [1]
* Edit v8 gitignore to allow trace_event copy
* Update V8 DEP trace_event as per deps/v8/DEPS [2]
[1] https://chromium.googlesource.com/v8/v8.git/+/3c67831
[2] https://chromium.googlesource.com/chromium/src/base/trace_event/common/+/4b09207e447ae5bd34643b4c6321bee7b76d35f9
Ref: https://github.com/nodejs/node/pull/5945
PR-URL: https://github.com/nodejs/node/pull/6111
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Diffstat (limited to 'deps/v8/src/compiler/access-info.cc')
| -rw-r--r-- | deps/v8/src/compiler/access-info.cc | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/deps/v8/src/compiler/access-info.cc b/deps/v8/src/compiler/access-info.cc index 612170e5b1..4a2a857029 100644 --- a/deps/v8/src/compiler/access-info.cc +++ b/deps/v8/src/compiler/access-info.cc @@ -8,9 +8,9 @@ #include "src/compilation-dependencies.h" #include "src/compiler/access-info.h" #include "src/field-index-inl.h" +#include "src/field-type.h" #include "src/objects-inl.h" // TODO(mstarzinger): Temporary cycle breaker! #include "src/type-cache.h" -#include "src/types-inl.h" namespace v8 { namespace internal { @@ -232,6 +232,9 @@ bool AccessInfoFactory::ComputePropertyAccessInfo( // Compute the receiver type. Handle<Map> receiver_map = map; + // Property lookups require the name to be internalized. + name = isolate()->factory()->InternalizeName(name); + // We support fast inline cases for certain JSObject getters. if (access_mode == AccessMode::kLoad && LookupSpecialFieldAccessor(map, name, access_info)) { @@ -242,7 +245,7 @@ bool AccessInfoFactory::ComputePropertyAccessInfo( do { // Lookup the named property on the {map}. Handle<DescriptorArray> descriptors(map->instance_descriptors(), isolate()); - int const number = descriptors->SearchWithCache(*name, *map); + int const number = descriptors->SearchWithCache(isolate(), *name, *map); if (number != DescriptorArray::kNotFound) { PropertyDetails const details = descriptors->GetDetails(number); if (access_mode == AccessMode::kStore) { @@ -277,8 +280,7 @@ bool AccessInfoFactory::ComputePropertyAccessInfo( // Extract the field type from the property details (make sure its // representation is TaggedPointer to reflect the heap object case). field_type = Type::Intersect( - Type::Convert<HeapType>( - handle(descriptors->GetFieldType(number), isolate()), zone()), + descriptors->GetFieldType(number)->Convert(zone()), Type::TaggedPointer(), zone()); if (field_type->Is(Type::None())) { // Store is not safe if the field type was cleared. @@ -454,10 +456,7 @@ bool AccessInfoFactory::LookupTransition(Handle<Map> map, Handle<Name> name, // Extract the field type from the property details (make sure its // representation is TaggedPointer to reflect the heap object case). field_type = Type::Intersect( - Type::Convert<HeapType>( - handle( - transition_map->instance_descriptors()->GetFieldType(number), - isolate()), + transition_map->instance_descriptors()->GetFieldType(number)->Convert( zone()), Type::TaggedPointer(), zone()); if (field_type->Is(Type::None())) { |