diff options
author | Ujjwal Sharma <usharma1998@gmail.com> | 2019-03-15 18:35:06 +0530 |
---|---|---|
committer | Refael Ackermann <refack@gmail.com> | 2019-03-28 16:36:18 -0400 |
commit | f579e1194046c50f2e6bb54348d48c8e7d1a53cf (patch) | |
tree | 9125787c758358365f74f9fd9673c14f57e67870 /deps/v8/src/objects/name-inl.h | |
parent | 2c73868b0471fbd4038f500d076df056cbf697fe (diff) | |
download | node-new-f579e1194046c50f2e6bb54348d48c8e7d1a53cf.tar.gz |
deps: update V8 to 7.4.288.13
PR-URL: https://github.com/nodejs/node/pull/26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'deps/v8/src/objects/name-inl.h')
-rw-r--r-- | deps/v8/src/objects/name-inl.h | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/deps/v8/src/objects/name-inl.h b/deps/v8/src/objects/name-inl.h index 3fda66f2a1..af1724b76d 100644 --- a/deps/v8/src/objects/name-inl.h +++ b/deps/v8/src/objects/name-inl.h @@ -7,8 +7,7 @@ #include "src/objects/name.h" -#include "src/heap/heap-inl.h" -#include "src/heap/heap-write-barrier.h" +#include "src/heap/heap-write-barrier-inl.h" #include "src/objects/map-inl.h" // Has to be the last include (doesn't have include guards): @@ -47,16 +46,18 @@ void Symbol::set_is_private_name() { bool Name::IsUniqueName() const { uint32_t type = map()->instance_type(); - return (type & (kIsNotStringMask | kIsNotInternalizedMask)) != - (kStringTag | kNotInternalizedTag); + bool result = (type & (kIsNotStringMask | kIsNotInternalizedMask)) != + (kStringTag | kNotInternalizedTag); + SLOW_DCHECK(result == HeapObject::IsUniqueName()); + return result; } uint32_t Name::hash_field() { - return READ_UINT32_FIELD(this, kHashFieldOffset); + return READ_UINT32_FIELD(*this, kHashFieldOffset); } void Name::set_hash_field(uint32_t value) { - WRITE_UINT32_FIELD(this, kHashFieldOffset, value); + WRITE_UINT32_FIELD(*this, kHashFieldOffset, value); } bool Name::Equals(Name other) { @@ -89,10 +90,7 @@ uint32_t Name::Hash() { uint32_t field = hash_field(); if (IsHashFieldComputed(field)) return field >> kHashShift; // Slow case: compute hash code and set it. Has to be a string. - // Also the string must be writable, because read-only strings will have their - // hash values precomputed. - return String::cast(*this)->ComputeAndSetHash( - Heap::FromWritableHeapObject(*this)->isolate()); + return String::cast(*this)->ComputeAndSetHash(); } bool Name::IsInterestingSymbol() const { |