diff options
| author | Michaël Zasso <targos@protonmail.com> | 2021-10-11 17:31:57 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2021-10-12 08:08:52 +0200 |
| commit | c9296b190f6c94b97ff250abfa6bb50a77b292a5 (patch) | |
| tree | f424119802f5f1920f67f118290a6a60807b673b /deps/v8/src/parsing | |
| parent | 5b358370ad94b94e103bc19a83cf88b0f2fde941 (diff) | |
| download | node-new-c9296b190f6c94b97ff250abfa6bb50a77b292a5.tar.gz | |
deps: V8: cherry-pick 2a0bc36dec12
Original commit message:
[parser] Fix the MSVC build
MSVC seems to instantiate the Parser::PreParserIdentifierToAstRawString
method despite it being unused. This CL adds an (unreachable)
definition for it.
Bug: v8:12266
Change-Id: I355ca82a9d6b7bc8cd16768a8df93e40f8bfc638
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199856
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77313}
Refs: https://github.com/v8/v8/commit/2a0bc36dec121c9f30e3c18e8ed1f0d0b4f2ed7c
PR-URL: https://github.com/nodejs/node/pull/40178
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'deps/v8/src/parsing')
| -rw-r--r-- | deps/v8/src/parsing/parser.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/deps/v8/src/parsing/parser.h b/deps/v8/src/parsing/parser.h index c5cc0c8030..5699148c3b 100644 --- a/deps/v8/src/parsing/parser.h +++ b/deps/v8/src/parsing/parser.h @@ -709,6 +709,13 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) { return arg; } + const AstRawString* PreParserIdentifierToAstRawString( + const PreParserIdentifier& arg) { + // This method definition is only needed due to an MSVC oddity that + // instantiates the method despite it being unused. See crbug.com/v8/12266 . + UNREACHABLE(); + } + IterationStatement* AsIterationStatement(BreakableStatement* s) { return s->AsIterationStatement(); } |