summaryrefslogtreecommitdiff
path: root/deps/v8/src/runtime/runtime-forin.cc
diff options
context:
space:
mode:
authorMichaël Zasso <targos@protonmail.com>2018-08-19 21:53:40 +0200
committerMichaël Zasso <targos@protonmail.com>2018-09-07 21:07:01 +0200
commit8dc159658c97ff04dfc08ff5bfcd1a1a17b98430 (patch)
tree979fc01ca821949d1a03989f7a6a875736524455 /deps/v8/src/runtime/runtime-forin.cc
parent127e7035ce70e70bdb62969f965d6941156c042c (diff)
downloadnode-new-8dc159658c97ff04dfc08ff5bfcd1a1a17b98430.tar.gz
deps: cherry-pick c608122 from upstream V8
Original commit message: [api][keys] Allow skipping indices for Proxies with GetPropertyNames Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54821} Refs: https://github.com/v8/v8/commit/c608122b85238397a43910246f5ff218eb43fb24 PR-URL: https://github.com/nodejs/node/pull/21983 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'deps/v8/src/runtime/runtime-forin.cc')
-rw-r--r--deps/v8/src/runtime/runtime-forin.cc3
1 files changed, 1 insertions, 2 deletions
diff --git a/deps/v8/src/runtime/runtime-forin.cc b/deps/v8/src/runtime/runtime-forin.cc
index 5df16faf46..ed1e226060 100644
--- a/deps/v8/src/runtime/runtime-forin.cc
+++ b/deps/v8/src/runtime/runtime-forin.cc
@@ -26,8 +26,7 @@ MaybeHandle<HeapObject> Enumerate(Isolate* isolate,
JSObject::MakePrototypesFast(receiver, kStartAtReceiver, isolate);
FastKeyAccumulator accumulator(isolate, receiver,
KeyCollectionMode::kIncludePrototypes,
- ENUMERABLE_STRINGS);
- accumulator.set_is_for_in(true);
+ ENUMERABLE_STRINGS, true);
// Test if we have an enum cache for {receiver}.
if (!accumulator.is_receiver_simple_enum()) {
Handle<FixedArray> keys;