diff options
| author | Matheus Marchini <matheus@sthima.com> | 2018-06-21 08:39:49 -0700 |
|---|---|---|
| committer | Matheus Marchini <matheus@sthima.com> | 2018-06-22 09:43:23 -0700 |
| commit | 7edd0a17af8d74dce7dd6c7554a8b8523f83efdc (patch) | |
| tree | a8932cbd538ac4943e3ff0428a0a6448daeaf44c /deps | |
| parent | c6e5043a250f8a6509f060ca9b743f4fe19fa4c6 (diff) | |
| download | node-new-7edd0a17af8d74dce7dd6c7554a8b8523f83efdc.tar.gz | |
deps: cherry-pick 70c4340 from upstream V8
Original commit message:
[log][api] Fix GCC 4.9 build failure
GCC 4.9 used on some Node.js CI machines complains when the control
reaches the end of a non-void function and no return is encountered.
R=bmeurer@google.com, ofrobots@google.com, yangguo@google.com
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I5af0192cb187eccbf34dbb60ff3ac2e4774af803
Reviewed-on: https://chromium-review.googlesource.com/1105619
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53861}
Refs: https://github.com/v8/v8/commit/70c43402ee04d482ff64e186e2faf43fe
PR-URL: https://github.com/nodejs/node/pull/21126
Refs: https://github.com/v8/v8/commit/aa6ce3e
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/src/api.cc | 4 | ||||
| -rw-r--r-- | deps/v8/src/log.cc | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/deps/v8/src/api.cc b/deps/v8/src/api.cc index d101bc419a..8a0dfca02b 100644 --- a/deps/v8/src/api.cc +++ b/deps/v8/src/api.cc @@ -10255,6 +10255,10 @@ const char* CodeEvent::GetCodeEventTypeName(CodeEventType code_event_type) { CODE_EVENTS_LIST(V) #undef V } + // The execution should never pass here + UNREACHABLE(); + // NOTE(mmarchini): Workaround to fix a compiler failure on GCC 4.9 + return "Unknown"; } CodeEventHandler::CodeEventHandler(Isolate* isolate) { diff --git a/deps/v8/src/log.cc b/deps/v8/src/log.cc index ccac04c6b6..99fe64723d 100644 --- a/deps/v8/src/log.cc +++ b/deps/v8/src/log.cc @@ -59,6 +59,10 @@ static v8::CodeEventType GetCodeEventTypeForTag( TAGS_LIST(V) #undef V } + // The execution should never pass here + UNREACHABLE(); + // NOTE(mmarchini): Workaround to fix a compiler failure on GCC 4.9 + return v8::CodeEventType::kUnknownType; } #define CALL_CODE_EVENT_HANDLER(Call) \ if (listener_) { \ |