diff options
| author | Joao Reis <reis@janeasystems.com> | 2019-11-01 08:39:18 +0100 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2020-11-15 16:47:17 +0100 |
| commit | bbc3f46572bfc2ffc460e66104bfccc0f4206a63 (patch) | |
| tree | 6c5cbafd18f8ec78b1f6e5ad8be934bc48c8d26c /deps | |
| parent | 0c988642dc74c437e5315de9d2b2e06bac12bed5 (diff) | |
| download | node-new-bbc3f46572bfc2ffc460e66104bfccc0f4206a63.tar.gz | |
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.
Refs: https://stackoverflow.com/q/38378693
PR-URL: https://github.com/nodejs/node/pull/32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/include/v8.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 32687d90b5..49fe066470 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -1834,9 +1834,11 @@ class V8_EXPORT ScriptCompiler { public: enum Encoding { ONE_BYTE, TWO_BYTE, UTF8 }; +#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */ V8_DEPRECATE_SOON( "This class takes ownership of source_stream, so use the constructor " "taking a unique_ptr to make these semantics clearer") +#endif StreamedSource(ExternalSourceStream* source_stream, Encoding encoding); StreamedSource(std::unique_ptr<ExternalSourceStream> source_stream, Encoding encoding); |