diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2023-03-24 18:30:56 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-24 17:30:56 +0000 |
| commit | f5239795b51dbc894b3ddcd49cf183151f414cdf (patch) | |
| tree | c8872674282ffda93409200a3f3a4bf324d6ff41 /deps | |
| parent | 5e7205145620c5993062bb3625117de1be3ccde7 (diff) | |
| download | node-new-f5239795b51dbc894b3ddcd49cf183151f414cdf.tar.gz | |
deps: V8: cherry-pick 215ccd593edb
Original commit message:
Use FlagValue::value() in SLOW_DCHECK
Previously SLOW_DCHECK used the non-constexpr bool() operator
of FlagValue, which cannot be used in constexpr. Switch to
FlagValue::value() instead for make it compile in constexpr.
Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
Reviewed-by: Jakob Linke <jgruber@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#86611}
Refs: https://github.com/v8/v8/commit/215ccd593edbf18170fa1aae109b6b1cccf0ccbf
PR-URL: https://github.com/nodejs/node/pull/47212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/src/common/checks.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/deps/v8/src/common/checks.h b/deps/v8/src/common/checks.h index a82fb4159f..33d7a8458b 100644 --- a/deps/v8/src/common/checks.h +++ b/deps/v8/src/common/checks.h @@ -15,7 +15,7 @@ #ifdef ENABLE_SLOW_DCHECKS #define SLOW_DCHECK(condition) \ - CHECK(!v8::internal::v8_flags.enable_slow_asserts || (condition)) + CHECK(!v8::internal::v8_flags.enable_slow_asserts.value() || (condition)) #define SLOW_DCHECK_IMPLIES(lhs, rhs) SLOW_DCHECK(!(lhs) || (rhs)) #else #define SLOW_DCHECK(condition) ((void)0) |