summaryrefslogtreecommitdiff
path: root/lib/console.js
diff options
context:
space:
mode:
authorgengjiawen <technicalcute@gmail.com>2018-11-15 23:40:36 +0800
committerRich Trott <rtrott@gmail.com>2018-11-20 11:46:38 -0800
commit08c14d98cdb029c72549a6709c2fd0befda5a463 (patch)
tree26e8816d6a4f2815c0e07a1d697f76fe78af8f11 /lib/console.js
parent527b6096a44a09cc557a92b73d6228b2c0e1e8ef (diff)
downloadnode-new-08c14d98cdb029c72549a6709c2fd0befda5a463.tar.gz
console: improve code readability
use object spread to make console code more readable PR-URL: https://github.com/nodejs/node/pull/24412 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'lib/console.js')
-rw-r--r--lib/console.js29
1 files changed, 16 insertions, 13 deletions
diff --git a/lib/console.js b/lib/console.js
index db22ee846f..b0f3055e91 100644
--- a/lib/console.js
+++ b/lib/console.js
@@ -97,23 +97,26 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
throw new ERR_CONSOLE_WRITABLE_STREAM('stderr');
}
- var prop = {
+ const prop = {
writable: true,
enumerable: false,
configurable: true
};
- prop.value = stdout;
- Object.defineProperty(this, '_stdout', prop);
- prop.value = stderr;
- Object.defineProperty(this, '_stderr', prop);
- prop.value = Boolean(ignoreErrors);
- Object.defineProperty(this, '_ignoreErrors', prop);
- prop.value = new Map();
- Object.defineProperty(this, '_times', prop);
- prop.value = createWriteErrorHandler(stdout);
- Object.defineProperty(this, '_stdoutErrorHandler', prop);
- prop.value = createWriteErrorHandler(stderr);
- Object.defineProperty(this, '_stderrErrorHandler', prop);
+ Object.defineProperty(this, '_stdout', { ...prop, value: stdout });
+ Object.defineProperty(this, '_stderr', { ...prop, value: stderr });
+ Object.defineProperty(this, '_ignoreErrors', {
+ ...prop,
+ value: Boolean(ignoreErrors),
+ });
+ Object.defineProperty(this, '_times', { ...prop, value: new Map() });
+ Object.defineProperty(this, '_stdoutErrorHandler', {
+ ...prop,
+ value: createWriteErrorHandler(stdout),
+ });
+ Object.defineProperty(this, '_stderrErrorHandler', {
+ ...prop,
+ value: createWriteErrorHandler(stderr),
+ });
if (typeof colorMode !== 'boolean' && colorMode !== 'auto')
throw new ERR_INVALID_ARG_VALUE('colorMode', colorMode);