diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-05-14 17:30:27 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-05-19 01:02:14 +0200 |
| commit | 70cc5da0f11a024cf5be1ff20fd885556c1d2153 (patch) | |
| tree | 0c6e6293015808b5dc89c21934372edd56a784c8 /lib/console.js | |
| parent | 143a2f8d67a81154bdb2849999837fb0a5c13d8e (diff) | |
| download | node-new-70cc5da0f11a024cf5be1ff20fd885556c1d2153.tar.gz | |
lib,src: use V8 API for collection inspection
Use a new public V8 API for inspecting weak collections and
collection iterators, rather than using V8-internal functions
to achieve this. This currently comes with a slight modification of
the output for inspecting iterators generated by `Set().entries()`.
Fixes: https://github.com/nodejs/node/issues/20409
PR-URL: https://github.com/nodejs/node/pull/20719
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'lib/console.js')
| -rw-r--r-- | lib/console.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/console.js b/lib/console.js index de2d11afe1..e8b89536b9 100644 --- a/lib/console.js +++ b/lib/console.js @@ -29,7 +29,7 @@ const { ERR_INVALID_ARG_VALUE, }, } = require('internal/errors'); -const { previewMapIterator, previewSetIterator } = require('internal/v8'); +const { previewEntries } = process.binding('util'); const { Buffer: { isBuffer } } = require('buffer'); const util = require('util'); const { @@ -345,7 +345,7 @@ Console.prototype.table = function(tabularData, properties) { const mapIter = isMapIterator(tabularData); if (mapIter) - tabularData = previewMapIterator(tabularData); + tabularData = previewEntries(tabularData); if (mapIter || isMap(tabularData)) { const keys = []; @@ -367,7 +367,7 @@ Console.prototype.table = function(tabularData, properties) { const setIter = isSetIterator(tabularData); if (setIter) - tabularData = previewSetIterator(tabularData); + tabularData = previewEntries(tabularData); const setlike = setIter || isSet(tabularData); if (setlike) { |