summaryrefslogtreecommitdiff
path: root/lib/events.js
diff options
context:
space:
mode:
authorzfx <502545703@qq.com>2020-02-18 22:35:08 +0800
committerRich Trott <rtrott@gmail.com>2020-03-07 10:47:12 -0800
commit1b3dbc9635d45c83e355d312b6114d58664b1e7a (patch)
tree9fa4f7df61875c50271db9e9f90f4dcd8279f65d /lib/events.js
parent960be159ac3b21bf8a4f8c3bca7e733d483fb7d9 (diff)
downloadnode-new-1b3dbc9635d45c83e355d312b6114d58664b1e7a.tar.gz
events: fix removeListener for Symbols
Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () => { }; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) => { console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn); }); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: https://github.com/nodejs/node/pull/31847 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib/events.js')
-rw-r--r--lib/events.js3
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/events.js b/lib/events.js
index 4a8311af05..b138979e13 100644
--- a/lib/events.js
+++ b/lib/events.js
@@ -31,7 +31,6 @@ const {
ObjectDefineProperty,
ObjectGetPrototypeOf,
ObjectSetPrototypeOf,
- ObjectKeys,
Promise,
PromiseReject,
PromiseResolve,
@@ -526,7 +525,7 @@ EventEmitter.prototype.removeAllListeners =
// Emit removeListener for all listeners on all events
if (arguments.length === 0) {
- for (const key of ObjectKeys(events)) {
+ for (const key of ReflectOwnKeys(events)) {
if (key === 'removeListener') continue;
this.removeAllListeners(key);
}