diff options
| author | Rich Trott <rtrott@gmail.com> | 2021-04-03 21:58:18 -0700 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2021-04-06 14:58:46 -0700 |
| commit | 1e4a2bcbee3559f9d665ba54a27991af9f24ff30 (patch) | |
| tree | a4b32eb013c8446f3b75b5d23704d287dc01061a /lib | |
| parent | 78b6f389d0f83b27178512baefe3872c4046c0a7 (diff) | |
| download | node-new-1e4a2bcbee3559f9d665ba54a27991af9f24ff30.tar.gz | |
crypto: remove check for condition that is always true
The value of `key` will always be `!= null` because earlier in the
function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy.
Remove condition that subsequently checks that `key != null`.
PR-URL: https://github.com/nodejs/node/pull/38072
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/internal/crypto/sig.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/internal/crypto/sig.js b/lib/internal/crypto/sig.js index d5c4c46192..f6b9d9d9a9 100644 --- a/lib/internal/crypto/sig.js +++ b/lib/internal/crypto/sig.js @@ -177,7 +177,7 @@ function signOneShot(algorithm, data, key, callback) { let keyData; if (isKeyObject(key) || isCryptoKey(key)) { ({ data: keyData } = preparePrivateKey(key)); - } else if (key != null && (isKeyObject(key.key) || isCryptoKey(key.key))) { + } else if (isKeyObject(key.key) || isCryptoKey(key.key)) { ({ data: keyData } = preparePrivateKey(key.key)); } else { keyData = createPrivateKey(key)[kHandle]; |