diff options
| author | Tobias Nießen <tniessen@tnie.de> | 2017-04-13 15:43:04 +0200 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-04-18 11:37:34 -0700 |
| commit | eaa0542eff274179a0befa80028b0e06628263bc (patch) | |
| tree | 94b2f672f7a113ce736088e95c5a8fc9b4b83688 /lib | |
| parent | 9e2634718662ed6f119cc8dd6de194cf6d8a4279 (diff) | |
| download | node-new-eaa0542eff274179a0befa80028b0e06628263bc.tar.gz | |
crypto: remove unused C++ parameter in sign/verify
Removes code in node_crypto.cc in Sign::SignFinal and
Verify::VerifyFinal which allowed to convert between buffers and
strings based on given encodings. The code is unused as crypto.js
only passes in and expects buffers and does the conversion itself.
The encoding parameter was removed from both methods.
PR-URL: https://github.com/nodejs/node/pull/12397
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/crypto.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/crypto.js b/lib/crypto.js index e4a320a76e..880c12d1b6 100644 --- a/lib/crypto.js +++ b/lib/crypto.js @@ -326,7 +326,7 @@ Sign.prototype.sign = function sign(options, encoding) { } } - var ret = this._handle.sign(toBuf(key), null, passphrase, rsaPadding, + var ret = this._handle.sign(toBuf(key), passphrase, rsaPadding, pssSaltLength); encoding = encoding || exports.DEFAULT_ENCODING; @@ -376,7 +376,7 @@ Verify.prototype.verify = function verify(options, signature, sigEncoding) { } } - return this._handle.verify(toBuf(key), toBuf(signature, sigEncoding), null, + return this._handle.verify(toBuf(key), toBuf(signature, sigEncoding), rsaPadding, pssSaltLength); }; |