diff options
| author | Yihong Wang <yh.wang@ibm.com> | 2017-10-21 23:16:50 -0700 |
|---|---|---|
| committer | Gibson Fahnestock <gibfahn@gmail.com> | 2017-11-13 23:17:34 +0000 |
| commit | 8680bb9f1a0163cfbdc4443c1eb2b56c5e443616 (patch) | |
| tree | 16d97c77379adba2d45dc17787f314b9e3cb1b1b /node.gyp | |
| parent | 21a7459d490d832d5d547833d527083e460999e1 (diff) | |
| download | node-new-8680bb9f1a0163cfbdc4443c1eb2b56c5e443616.tar.gz | |
src: explicitly register built-in modules
Previously, built-in modules are registered before main() via
__attribute__((constructor)) mechanism in GCC and similiar
mechanism in MSVC. This causes some issues when node is built as
static library. Calling module registration function for built-in
modules in node::Init() helps to avoid the issues.
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/16565
Refs: https://github.com/nodejs/node/pull/14986#issuecomment-332758206
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'node.gyp')
| -rw-r--r-- | node.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -808,6 +808,7 @@ 'defines': [ 'NODE_WANT_INTERNALS=1' ], 'sources': [ + 'test/cctest/node_module_reg.cc', 'test/cctest/node_test_fixture.cc', 'test/cctest/test_aliased_buffer.cc', 'test/cctest/test_base64.cc', |