diff options
| author | Rich Trott <rtrott@gmail.com> | 2021-07-16 07:12:36 -0700 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2021-07-19 07:27:19 -0700 |
| commit | c154c6c5cfc464658dfae331b2d68c9daaca3f8e (patch) | |
| tree | 6bb87f3f2f167297221197ee6e4fb33ca9bd0f77 /onboarding.md | |
| parent | 057e31df7f013d5326e7d810efeef9a72e49dcee (diff) | |
| download | node-new-c154c6c5cfc464658dfae331b2d68c9daaca3f8e.tar.gz | |
doc: remove outdated step in onboarding exercise
The GitHub bot will leave a comment asking people to thumbs-up a fast
track request so there is no need to manually leave such a comment.
PR-URL: https://github.com/nodejs/node/pull/39410
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'onboarding.md')
| -rw-r--r-- | onboarding.md | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/onboarding.md b/onboarding.md index adcf23f41a..ae65f07f37 100644 --- a/onboarding.md +++ b/onboarding.md @@ -204,12 +204,12 @@ needs to be pointed out separately during the onboarding. so that when the commit lands, the nomination issue url will be automatically closed. * Label your pull request with the `doc`, `notable-change`, and `fast-track` - labels. + labels. The `fast-track` label should cause the Node.js GitHub bot to post a + comment in the pull request asking collaborators to approve the pull request + by leaving a 👍 reaction on the comment. * Run CI on the pull request. Use the `node-test-pull-request` CI task. * After two Collaborator approvals for the change and two Collaborator approvals - for fast-tracking, land the pull request. -* Leave a comment in the pull request: - `Please 👍 this comment to approve fast-tracking`. + for fast-tracking, land the PR. * If there are not enough approvals within a reasonable time, consider the single approval of the onboarding TSC member sufficient, and land the pull request. |