diff options
| author | Alexandre Ferrando <alferpal@gmail.com> | 2019-10-26 16:59:34 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-10-31 14:11:05 +0100 |
| commit | 99c1238f54a34acae7a4bde1c1e031fbf5d4d214 (patch) | |
| tree | e194c67fbb35922186bf33b7b391eb3b78e76754 /src/diagnosticfilename-inl.h | |
| parent | 7477f90b5c9e903b1680cae7e826b5bb8ed545f5 (diff) | |
| download | node-new-99c1238f54a34acae7a4bde1c1e031fbf5d4d214.tar.gz | |
src: change env.h includes for forward declarations
Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.
Refs: https://github.com/nodejs/node/issues/27531
PR-URL: https://github.com/nodejs/node/pull/30133
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Diffstat (limited to 'src/diagnosticfilename-inl.h')
| -rw-r--r-- | src/diagnosticfilename-inl.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/diagnosticfilename-inl.h b/src/diagnosticfilename-inl.h index 58a3a933ac..a0d44fd56b 100644 --- a/src/diagnosticfilename-inl.h +++ b/src/diagnosticfilename-inl.h @@ -4,10 +4,10 @@ #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS #include "node_internals.h" -#include "env-inl.h" - namespace node { +class Environment; + inline DiagnosticFilename::DiagnosticFilename( Environment* env, const char* prefix, |