diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2020-12-15 06:17:55 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2020-12-17 05:06:57 +0100 |
| commit | eb14b103701650d89e060f61c0e527e43a9e8c39 (patch) | |
| tree | faeda752faa874b060d3154d987dbb803afcfc88 /src/node_buffer.cc | |
| parent | e51267bd4d0a0b611c4f24a85fcf230cefc92fdc (diff) | |
| download | node-new-eb14b103701650d89e060f61c0e527e43a9e8c39.tar.gz | |
src: remove unnecessary ToLocalChecked call
PR-URL: https://github.com/nodejs/node/pull/36523
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/node_buffer.cc')
| -rw-r--r-- | src/node_buffer.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/node_buffer.cc b/src/node_buffer.cc index 21c7817332..77efa7bae2 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -496,18 +496,19 @@ void StringSlice(const FunctionCallbackInfo<Value>& args) { size_t length = end - start; Local<Value> error; - MaybeLocal<Value> ret = + MaybeLocal<Value> maybe_ret = StringBytes::Encode(isolate, buffer.data() + start, length, encoding, &error); - if (ret.IsEmpty()) { + Local<Value> ret; + if (!maybe_ret.ToLocal(&ret)) { CHECK(!error.IsEmpty()); isolate->ThrowException(error); return; } - args.GetReturnValue().Set(ret.ToLocalChecked()); + args.GetReturnValue().Set(ret); } |