diff options
| author | Darshan Sen <raisinten@gmail.com> | 2022-07-15 09:40:56 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-15 05:10:56 +0100 |
| commit | a6e23292464eb7dac1c9150fb0bde7a3e7b211a2 (patch) | |
| tree | 51899ccbd8a873f634140fbcf636a863c018d19e /src/node_internals.h | |
| parent | 4917f444e60040843e997cb2770d0d7af5bb4fde (diff) | |
| download | node-new-a6e23292464eb7dac1c9150fb0bde7a3e7b211a2.tar.gz | |
src: pass only Isolate* and env_vars to EnabledDebugList::Parse()
The function doesn't require access to the entire Environment object, so
this change just passes what it needs.
Addresses this TODO -
https://github.com/nodejs/node/blob/71691e53d601a4cf3eab3b33cebe4cc9f50c8470/src/env.cc#L372-L374
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/43668
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/node_internals.h')
| -rw-r--r-- | src/node_internals.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/node_internals.h b/src/node_internals.h index 4be91ca699..464b6685de 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -290,7 +290,10 @@ class ThreadPoolWork { #endif // defined(__POSIX__) && !defined(__ANDROID__) && !defined(__CloudABI__) namespace credentials { -bool SafeGetenv(const char* key, std::string* text, Environment* env = nullptr); +bool SafeGetenv(const char* key, + std::string* text, + std::shared_ptr<KVStore> env_vars = nullptr, + v8::Isolate* isolate = nullptr); } // namespace credentials void DefineZlibConstants(v8::Local<v8::Object> target); |