diff options
| author | Yagiz Nizipli <yagiz@nizipli.com> | 2023-03-02 08:23:23 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-02 13:23:23 +0000 |
| commit | 7bd909b603475aeba1d97da3e08cdcde3339fc19 (patch) | |
| tree | c499da5de6a11ddf61bb46ceb7b63610c32a56a8 /src/node_url.cc | |
| parent | 0abe5ecacbec39f078750d87a2ff8ad5e9b8ce0e (diff) | |
| download | node-new-7bd909b603475aeba1d97da3e08cdcde3339fc19.tar.gz | |
url: set `formatUrl` method as no side effect
PR-URL: https://github.com/nodejs/node/pull/46884
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'src/node_url.cc')
| -rw-r--r-- | src/node_url.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_url.cc b/src/node_url.cc index 1e8f6772fb..014a758b7d 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -313,7 +313,7 @@ void Initialize(Local<Object> target, void* priv) { SetMethod(context, target, "parse", Parse); SetMethod(context, target, "updateUrl", UpdateUrl); - SetMethod(context, target, "formatUrl", FormatUrl); + SetMethodNoSideEffect(context, target, "formatUrl", FormatUrl); SetMethodNoSideEffect(context, target, "domainToASCII", DomainToASCII); SetMethodNoSideEffect(context, target, "domainToUnicode", DomainToUnicode); |