diff options
| author | Node.js GitHub Bot <github-bot@iojs.org> | 2023-04-25 01:47:50 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-25 00:47:50 +0000 |
| commit | 25b6ddf664d7fc466b6dff4fe438233a28df65b0 (patch) | |
| tree | 813f6baff0aad138c386733c77a76ceffcef9a85 /src | |
| parent | dccd25e5bb524d56bc8ad7f703204a9852f574a4 (diff) | |
| download | node-new-25b6ddf664d7fc466b6dff4fe438233a28df65b0.tar.gz | |
deps: update ada to 2.2.0
PR-URL: https://github.com/nodejs/node/pull/47678
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/node_url.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/node_url.cc b/src/node_url.cc index e8df279626..02f9e58097 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -161,7 +161,7 @@ void BindingData::Format(const FunctionCallbackInfo<Value>& args) { Isolate* isolate = env->isolate(); Utf8Value href(isolate, args[0].As<String>()); - const bool fragment = args[1]->IsTrue(); + const bool hash = args[1]->IsTrue(); const bool unicode = args[2]->IsTrue(); const bool search = args[3]->IsTrue(); const bool auth = args[4]->IsTrue(); @@ -172,8 +172,8 @@ void BindingData::Format(const FunctionCallbackInfo<Value>& args) { auto out = ada::parse<ada::url>(href.ToStringView()); CHECK(out); - if (!fragment) { - out->fragment = std::nullopt; + if (!hash) { + out->hash = std::nullopt; } if (unicode) { |