summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorYagiz Nizipli <yagiz@nizipli.com>2023-04-29 10:04:57 -0400
committerGitHub <noreply@github.com>2023-04-29 14:04:57 +0000
commit4c620427741878a1c2d97533d7ebe175eed8c29f (patch)
treec75f52fcfc5a007e977ff378ab06fcd0c1f6fe24 /src
parentadf332be32a32120b2d4bcac2efe6ad8f9a6d37d (diff)
downloadnode-new-4c620427741878a1c2d97533d7ebe175eed8c29f.tar.gz
src: avoid copying string in fs_permission
PR-URL: https://github.com/nodejs/node/pull/47746 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/permission/fs_permission.cc2
-rw-r--r--src/permission/fs_permission.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
index 05efc790f0..7a8a0ba251 100644
--- a/src/permission/fs_permission.cc
+++ b/src/permission/fs_permission.cc
@@ -89,7 +89,7 @@ void FSPermission::Apply(const std::string& allow, PermissionScope scope) {
}
}
-void FSPermission::GrantAccess(PermissionScope perm, std::string res) {
+void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
const std::string path = WildcardIfDir(res);
if (perm == PermissionScope::kFileSystemRead) {
granted_in_fs_.Insert(path);
diff --git a/src/permission/fs_permission.h b/src/permission/fs_permission.h
index 93c4272761..f393c6a042 100644
--- a/src/permission/fs_permission.h
+++ b/src/permission/fs_permission.h
@@ -130,7 +130,7 @@ class FSPermission final : public PermissionBase {
};
private:
- void GrantAccess(PermissionScope scope, std::string param);
+ void GrantAccess(PermissionScope scope, const std::string& param);
void RestrictAccess(PermissionScope scope,
const std::vector<std::string>& params);
// fs granted on startup